Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 25870005: Canonical name change: windows-949 => EUC-KR (Closed)

Created:
7 years, 2 months ago by jungshik at Google
Modified:
7 years, 2 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Canonical name change: windows-949 => EUC-KR This is to be compliant with the HTML5 encoding spec. The expected result for encoding-labels.html was updated accordingly to pass EUC-KR related tests. It has to be noted that EUC-KR is a far more widely used encoding label than windows-949. Strictly speaking, Windows-949 is a superset of EUC-KR, but an widely accepted practice in the web is to treat them synonymously as codified in HTML 5. In addition, 'TextEncoding::domName' became unnecessary (http://trac.webkit.org/changeset/43279) so that it's removed. THe chromium side of change is https://codereview.chromium.org/26439002. BUG=277027 TEST=fast/encoding/api/* and fast/encoding/euckr-name.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158972 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159125

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : update legacy-encode result and cl description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -43 lines) Patch
M LayoutTests/fast/encoding/api/encoding-labels-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/encoding/api/legacy-encode-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextCodecICU.cpp View 3 chunks +14 lines, -10 lines 0 comments Download
M Source/wtf/text/TextEncoding.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/text/TextEncoding.cpp View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jungshik at Google
Can you take a look? BTW, this will require a Chromium side change as well. ...
7 years, 2 months ago (2013-10-03 22:39:40 UTC) #1
jsbell
lgtm
7 years, 2 months ago (2013-10-03 23:03:06 UTC) #2
jungshik at Google
Chrome-side change: https://codereview.chromium.org/25769005/
7 years, 2 months ago (2013-10-04 00:06:32 UTC) #3
jungshik at Google
thakis, would you review? :-)
7 years, 2 months ago (2013-10-04 17:40:05 UTC) #4
Nico
Do other browsers comply to the HTML5 encoding spec?
7 years, 2 months ago (2013-10-04 21:00:11 UTC) #5
jungshik at Google
On 2013/10/04 21:00:11, Nico wrote: > Do other browsers comply to the HTML5 encoding spec? ...
7 years, 2 months ago (2013-10-04 21:07:31 UTC) #6
Nico
lgtm
7 years, 2 months ago (2013-10-04 21:08:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/25870005/11001
7 years, 2 months ago (2013-10-04 23:14:39 UTC) #8
commit-bot: I haz the power
Change committed as 158972
7 years, 2 months ago (2013-10-05 01:31:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/25870005/11001
7 years, 2 months ago (2013-10-08 16:45:52 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 16:46:31 UTC) #11
Message was sent while issue was closed.
Change committed as 159125

Powered by Google App Engine
This is Rietveld 408576698