PlzNavigate: don't send unexpected form urls to the browser

PlzNavigate: don't send unexpected form urls to the browser

Layout tests sometimes attempt to load urls of the form about:blank?foo,
which are sent to the browser since they are not about:blank. However
the browser does not expect these urls, and they are converted to
about:blank when sanitizing the params received in the BeginNavigation
IPC. Don't send these urls to the browser when layout tests are active.

BUG=608372
Review-Url: https://codereview.chromium.org/2618363002
Cr-Commit-Position: refs/heads/master@{#442557}
Committed: https://chromium.googlesource.com/chromium/src/+/14d8238284dab1d8aaad166d5f1ba03cceaf793b

[clamy, 2017-01-09 16:34:30]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[clamy, 2017-01-09 16:34:52]

Description was changed from

==========
PlzNavigate: don't send unexpected form urls to the browser

Layout tests sometimes attempt to load urls of the form about:blank?foo,
which are sent to the browser since they are not about:blank. However
the browser does not expect these urls, and they are converted to
about:blank when sanitizing the params received in the BeginNavigation
IPC. Don't send these urls to the browser when layout tests are active.

BUG=608372
==========

to

==========
PlzNavigate: don't send unexpected form urls to the browser

Layout tests sometimes attempt to load urls of the form about:blank?foo,
which are sent to the browser since they are not about:blank. However
the browser does not expect these urls, and they are converted to
about:blank when sanitizing the params received in the BeginNavigation
IPC. Don't send these urls to the browser when layout tests are active.

BUG=608372
==========

[clamy, 2017-01-09 16:34:52]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[commit-bot: I haz the power, 2017-01-09 16:34:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2017-01-09 16:35:03]

@nasko: PTAL

[commit-bot: I haz the power, 2017-01-09 18:08:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:08:41]

Dry run: This issue passed the CQ dry run.

[nasko, 2017-01-09 23:57:51]

LGTM

https://codereview.chromium.org/2618363002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2618363002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:5406: if (url.SchemeIs(url::kAboutScheme)
&& url.path() == "blank")
Ugh, is "blank: really parsed as the "path" part of an URL?!

[clamy, 2017-01-10 12:13:52]

Thanks!

https://codereview.chromium.org/2618363002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2618363002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:5406: if (url.SchemeIs(url::kAboutScheme)
&& url.path() == "blank")
On 2017/01/09 23:57:51, nasko wrote:
> Ugh, is "blank: really parsed as the "path" part of an URL?!

Yeah I know. I had to print all parts of the url to find what it was parsed to.
Very not intuitive.

[clamy, 2017-01-10 12:14:00]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2017-01-10 12:14:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 12:17:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484050440728280, "parent_rev":
"e368398a3a5357a8742f3829ef08cc45080fb808", "commit_rev":
"14d8238284dab1d8aaad166d5f1ba03cceaf793b"}

[commit-bot: I haz the power, 2017-01-10 12:18:43]

Description was changed from

==========
PlzNavigate: don't send unexpected form urls to the browser

Layout tests sometimes attempt to load urls of the form about:blank?foo,
which are sent to the browser since they are not about:blank. However
the browser does not expect these urls, and they are converted to
about:blank when sanitizing the params received in the BeginNavigation
IPC. Don't send these urls to the browser when layout tests are active.

BUG=608372
==========

to

==========
PlzNavigate: don't send unexpected form urls to the browser

Layout tests sometimes attempt to load urls of the form about:blank?foo,
which are sent to the browser since they are not about:blank. However
the browser does not expect these urls, and they are converted to
about:blank when sanitizing the params received in the BeginNavigation
IPC. Don't send these urls to the browser when layout tests are active.

BUG=608372

Review-Url: https://codereview.chromium.org/2618363002
Cr-Commit-Position: refs/heads/master@{#442557}
Committed:
https://chromium.googlesource.com/chromium/src/+/14d8238284dab1d8aaad166d5f1b...
==========

[commit-bot: I haz the power, 2017-01-10 12:18:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14d8238284dab1d8aaad166d5f1b...