PlzNavigate: don't send unexpected form urls to the browser

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 5380 matching lines @@
           base::TimeTicks::Now();
     }
   }
 
   // PlzNavigate: if the navigation is not synchronous, send it to the browser.
   // This includes navigations with no request being sent to the network stack.
   if (IsBrowserSideNavigationEnabled() &&
       info.urlRequest.checkForBrowserSideNavigation() &&
       ShouldMakeNetworkRequestForURL(url)) {
     if (info.defaultPolicy == blink::WebNavigationPolicyCurrentTab) {
+      if (RenderThreadImpl::current() &&
+          RenderThreadImpl::current()->layout_test_mode()) {
+        // Layout tests sometimes attempt to load urls of the form
+        // about:blank?foo which the browser doesn't expect and will convert to
+        // about:blank. Don't send these to the browser.
+        if (url.SchemeIs(url::kAboutScheme) && url.path() == "blank")

[nasko, 2017/01/09 23:57:51]

Ugh, is "blank: really parsed as the "path" part of an URL?!

[clamy, 2017/01/10 12:13:52]

Yeah I know. I had to print all parts of the url to find what it was parsed to.
Very not intuitive.

+          return info.defaultPolicy;
+      }
+
       BeginNavigation(info);
       return blink::WebNavigationPolicyHandledByClient;
     } else {
       LoadURLExternally(info.urlRequest, info.defaultPolicy);
       return blink::WebNavigationPolicyIgnore;
     }
   }
 
   return info.defaultPolicy;
 }
@@ skipping 1365 matching lines @@
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content