Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2618333004:
Add ShelfWindowWatcher support for pre-existing windows. (Closed)
|
Created:
3 years, 11 months ago by msw Modified:
3 years, 11 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd ShelfWindowWatcher support for pre-existing windows.
Call OnDisplayAdded from ctor; consolidate code.
Call OnUserWindowAdded for each pre-existing window.
(catches windows constructed earlier than the shelf [window watcher])
Add ShelfWindowWatcherSessionStartTest.PreExistingWindow.
BUG=679088
TEST="chrome --mash" shows a QuickLaunch shelf item.
R=jamescook@chromium.org
Review-Url: https://codereview.chromium.org/2618333004
Cr-Commit-Position: refs/heads/master@{#442678}
Committed: https://chromium.googlesource.com/chromium/src/+/24ccd0688d195440d8c37f0f256d9a379a25db25
Patch Set 1 #Patch Set 2 : Cleanup; add a test. #
Total comments: 4
Patch Set 3 : Address comments. #
Messages
Total messages: 21 (15 generated)
Description was changed from ========== Add ShelfWindowWatcher support for pre-existing windows. BUG=679088 ========== to ========== Add ShelfWindowWatcher support for pre-existing windows. Call OnDisplayAdded from ctor; consolidate code. Call OnUserWindowAdded for each pre-existing window. (catches windows constructed earlier than the shelf [window watcher]) BUG=679088 TEST="chrome --mash" shows a QuickLaunch shelf item. R=jamescook@chromium.org ==========
msw@chromium.org changed reviewers: + jamescook@chromium.org
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Description was changed from ========== Add ShelfWindowWatcher support for pre-existing windows. Call OnDisplayAdded from ctor; consolidate code. Call OnUserWindowAdded for each pre-existing window. (catches windows constructed earlier than the shelf [window watcher]) BUG=679088 TEST="chrome --mash" shows a QuickLaunch shelf item. R=jamescook@chromium.org ========== to ========== Add ShelfWindowWatcher support for pre-existing windows. Call OnDisplayAdded from ctor; consolidate code. Call OnUserWindowAdded for each pre-existing window. (catches windows constructed earlier than the shelf [window watcher]) Add ShelfWindowWatcherSessionStartTest.PreExistingWindow. BUG=679088 TEST="chrome --mash" shows a QuickLaunch shelf item. R=jamescook@chromium.org ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hey James, please take a look; thanks! The test passed before *and* after your revert: https://codereview.chromium.org/2619943002
LGTM. Thanks for writing a test. https://codereview.chromium.org/2618333004/diff/20001/ash/common/shelf/shelf_... File ash/common/shelf/shelf_window_watcher_unittest.cc (right): https://codereview.chromium.org/2618333004/diff/20001/ash/common/shelf/shelf_... ash/common/shelf/shelf_window_watcher_unittest.cc:9: #include "ash/common/test/test_session_state_delegate.h" nit: still needed? https://codereview.chromium.org/2618333004/diff/20001/ash/common/shelf/shelf_... ash/common/shelf/shelf_window_watcher_unittest.cc:338: class ShelfWindowWatcherSessionStartTest : public ShelfWindowWatcherTest { For future reference there is also NoSessionAshTestBase https://cs.chromium.org/chromium/src/ash/test/ash_test_base.h?type=cs&q=f:ash...
Comments addressed, take another look if interested; thanks! https://codereview.chromium.org/2618333004/diff/20001/ash/common/shelf/shelf_... File ash/common/shelf/shelf_window_watcher_unittest.cc (right): https://codereview.chromium.org/2618333004/diff/20001/ash/common/shelf/shelf_... ash/common/shelf/shelf_window_watcher_unittest.cc:9: #include "ash/common/test/test_session_state_delegate.h" On 2017/01/10 19:51:15, James Cook wrote: > nit: still needed? Changed to ash/common/session/session_state_delegate.h; thanks! https://codereview.chromium.org/2618333004/diff/20001/ash/common/shelf/shelf_... ash/common/shelf/shelf_window_watcher_unittest.cc:338: class ShelfWindowWatcherSessionStartTest : public ShelfWindowWatcherTest { On 2017/01/10 19:51:15, James Cook wrote: > For future reference there is also NoSessionAshTestBase > > https://cs.chromium.org/chromium/src/ash/test/ash_test_base.h?type=cs&q=f:ash... I updated my test fixture to use that; thanks!
The CQ bit was checked by msw@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org Link to the patchset: https://codereview.chromium.org/2618333004/#ps40001 (title: "Address comments.")
still lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484078794040820,
"parent_rev": "683958557e344ac2fc7fdcdcfd45333f71d5c9e7", "commit_rev":
"24ccd0688d195440d8c37f0f256d9a379a25db25"}
Message was sent while issue was closed.
Description was changed from ========== Add ShelfWindowWatcher support for pre-existing windows. Call OnDisplayAdded from ctor; consolidate code. Call OnUserWindowAdded for each pre-existing window. (catches windows constructed earlier than the shelf [window watcher]) Add ShelfWindowWatcherSessionStartTest.PreExistingWindow. BUG=679088 TEST="chrome --mash" shows a QuickLaunch shelf item. R=jamescook@chromium.org ========== to ========== Add ShelfWindowWatcher support for pre-existing windows. Call OnDisplayAdded from ctor; consolidate code. Call OnUserWindowAdded for each pre-existing window. (catches windows constructed earlier than the shelf [window watcher]) Add ShelfWindowWatcherSessionStartTest.PreExistingWindow. BUG=679088 TEST="chrome --mash" shows a QuickLaunch shelf item. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2618333004 Cr-Commit-Position: refs/heads/master@{#442678} Committed: https://chromium.googlesource.com/chromium/src/+/24ccd0688d195440d8c37f0f256d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/24ccd0688d195440d8c37f0f256d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
