Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2618313003: Use WebURLResponse to pass the navigation preload response from SWContextClient to FetchEvent. (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
tkent, falken
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, falken+watch_chromium.org, haraken, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mlamouri+watch-content_chromium.org, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use WebURLResponse to pass the navigation preload response from SWContextClient to FetchEvent. Currently we use WebServiceWorkerResponse to pass the navigation preload response from ServiceWorkerContextClient::NavigationPreloadRequest to FetchEvent. But to show the network timing information in DevTool's network tab, we need the timing information in ResourceResponseInfo in blnik side. So this cl change the code to use WebURLResponse which contains the timing information. BUG=649558 Review-Url: https://codereview.chromium.org/2618313003 Cr-Commit-Position: refs/heads/master@{#442813} Committed: https://chromium.googlesource.com/chromium/src/+/b9937a428eaf8d98b0ad9e05707ab2d0559a62b3

Patch Set 1 #

Total comments: 2

Patch Set 2 : incorporated falken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -37 lines) Patch
M content/renderer/service_worker/service_worker_context_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 5 chunks +9 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
horo
falken@ Could you please review this?
3 years, 11 months ago (2017-01-10 11:27:57 UTC) #6
falken
lgtm https://codereview.chromium.org/2618313003/diff/1/content/renderer/service_worker/service_worker_context_client.cc File content/renderer/service_worker/service_worker_context_client.cc (right): https://codereview.chromium.org/2618313003/diff/1/content/renderer/service_worker/service_worker_context_client.cc#newcode264 content/renderer/service_worker/service_worker_context_client.cc:264: // TODO(horo): Set report_security_info true when DevTool is ...
3 years, 11 months ago (2017-01-11 01:15:18 UTC) #9
horo
Thank you! https://codereview.chromium.org/2618313003/diff/1/content/renderer/service_worker/service_worker_context_client.cc File content/renderer/service_worker/service_worker_context_client.cc (right): https://codereview.chromium.org/2618313003/diff/1/content/renderer/service_worker/service_worker_context_client.cc#newcode264 content/renderer/service_worker/service_worker_context_client.cc:264: // TODO(horo): Set report_security_info true when DevTool ...
3 years, 11 months ago (2017-01-11 01:40:54 UTC) #10
horo
tkent@ Could you please review third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.*?
3 years, 11 months ago (2017-01-11 01:42:09 UTC) #12
tkent
lgtm
3 years, 11 months ago (2017-01-11 01:44:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618313003/20001
3 years, 11 months ago (2017-01-11 01:53:26 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/368399)
3 years, 11 months ago (2017-01-11 04:01:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618313003/20001
3 years, 11 months ago (2017-01-11 04:18:06 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 05:34:13 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9937a428eaf8d98b0ad9e05707a...

Powered by Google App Engine
This is Rietveld 408576698