Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Issue 2618313003: Use WebURLResponse to pass the navigation preload response from SWContextClient to FetchEvent. (Closed)
Patch Set: incorporated falken's comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
index e5ed5d50a789b6fe23b99f6c95b5346ebaae8142..8f4f9a01776170ab3cd3d5a5a4dedf2b40072320 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
@@ -12,8 +12,8 @@
#include "modules/fetch/Response.h"
#include "modules/serviceworkers/ServiceWorkerError.h"
#include "modules/serviceworkers/ServiceWorkerGlobalScope.h"
+#include "public/platform/WebURLResponse.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerError.h"
-#include "public/platform/modules/serviceworker/WebServiceWorkerResponse.h"
#include "wtf/PtrUtil.h"
#include "wtf/RefPtr.h"
@@ -107,7 +107,7 @@ FetchEvent::FetchEvent(ScriptState* scriptState,
void FetchEvent::onNavigationPreloadResponse(
ScriptState* scriptState,
- std::unique_ptr<WebServiceWorkerResponse> response,
+ std::unique_ptr<WebURLResponse> response,
std::unique_ptr<WebDataConsumerHandle> dataConsumeHandle) {
if (!scriptState->contextIsValid())
return;
@@ -117,17 +117,17 @@ void FetchEvent::onNavigationPreloadResponse(
new BodyStreamBuffer(scriptState, new BytesConsumerForDataConsumerHandle(
scriptState->getExecutionContext(),
std::move(dataConsumeHandle))));
- const WebVector<WebURL>& webURLList = response->urlList();
- // Navigation preload doesn't support redirect.
- DCHECK_EQ(1u, webURLList.size());
Vector<KURL> urlList(1);
- urlList[0] = webURLList[0];
+ urlList[0] = response->url();
responseData->setURLList(urlList);
- responseData->setStatus(response->status());
- responseData->setStatusMessage(response->statusText());
- responseData->setResponseTime(response->responseTime());
- for (const auto& header : response->headers())
+ responseData->setStatus(response->httpStatusCode());
+ responseData->setStatusMessage(response->httpStatusText());
+ responseData->setResponseTime(response->toResourceResponse().responseTime());
+ const HTTPHeaderMap& headers(
+ response->toResourceResponse().httpHeaderFields());
+ for (const auto& header : headers) {
responseData->headerList()->append(header.key, header.value);
+ }
FetchResponseData* taintedResponse =
responseData->createBasicFilteredResponse();
m_preloadResponseProperty->resolve(

Powered by Google App Engine
This is Rietveld 408576698