Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: components/ntp_snippets/BUILD.gn

Issue 2618243004: Add a unit test for the BookmarkSuggestionsProvider. (Closed)
Patch Set: renamed MockProvider and updated tests comments about expected behavior Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/BUILD.gn
diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn
index fc9837331b04e67cfdb52d4cb5209ad72bb5a2ee..1bac0cf5bae060e3d52cf17e9ecd3b5e62d70632 100644
--- a/components/ntp_snippets/BUILD.gn
+++ b/components/ntp_snippets/BUILD.gn
@@ -129,6 +129,7 @@ source_set("unit_tests") {
testonly = true
sources = [
"bookmarks/bookmark_last_visit_utils_unittest.cc",
+ "bookmarks/bookmark_suggestions_provider_unittest.cc",
"category_rankers/click_based_category_ranker_unittest.cc",
"category_rankers/constant_category_ranker_unittest.cc",
"category_unittest.cc",
@@ -184,6 +185,10 @@ source_set("test_support") {
"category_rankers/fake_category_ranker.h",
"category_rankers/mock_category_ranker.cc",
"category_rankers/mock_category_ranker.h",
+ "fake_content_suggestions_provider_observer.cc",
+ "fake_content_suggestions_provider_observer.h",
+ "mock_content_suggestions_provider.cc",
+ "mock_content_suggestions_provider.h",
"mock_content_suggestions_provider_observer.cc",
"mock_content_suggestions_provider_observer.h",
"offline_pages/offline_pages_test_utils.cc",
@@ -196,5 +201,6 @@ source_set("test_support") {
"//components/offline_pages/core",
"//components/offline_pages/core:test_support",
"//testing/gmock",
+ "//testing/gtest",
]
}
« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698