Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: components/ntp_snippets/BUILD.gn

Issue 2618243004: Add a unit test for the BookmarkSuggestionsProvider. (Closed)
Patch Set: renamed MockProvider and updated tests comments about expected behavior Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/android/rules.gni") 9 import("//build/config/android/rules.gni")
10 } 10 }
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 "category_info.h", 122 "category_info.h",
123 "category_status.h", 123 "category_status.h",
124 ] 124 ]
125 } 125 }
126 } 126 }
127 127
128 source_set("unit_tests") { 128 source_set("unit_tests") {
129 testonly = true 129 testonly = true
130 sources = [ 130 sources = [
131 "bookmarks/bookmark_last_visit_utils_unittest.cc", 131 "bookmarks/bookmark_last_visit_utils_unittest.cc",
132 "bookmarks/bookmark_suggestions_provider_unittest.cc",
132 "category_rankers/click_based_category_ranker_unittest.cc", 133 "category_rankers/click_based_category_ranker_unittest.cc",
133 "category_rankers/constant_category_ranker_unittest.cc", 134 "category_rankers/constant_category_ranker_unittest.cc",
134 "category_unittest.cc", 135 "category_unittest.cc",
135 "content_suggestions_service_unittest.cc", 136 "content_suggestions_service_unittest.cc",
136 "offline_pages/recent_tab_suggestions_provider_unittest.cc", 137 "offline_pages/recent_tab_suggestions_provider_unittest.cc",
137 "physical_web_pages/physical_web_page_suggestions_provider_unittest.cc", 138 "physical_web_pages/physical_web_page_suggestions_provider_unittest.cc",
138 "remote/ntp_snippet_unittest.cc", 139 "remote/ntp_snippet_unittest.cc",
139 "remote/ntp_snippets_fetcher_unittest.cc", 140 "remote/ntp_snippets_fetcher_unittest.cc",
140 "remote/ntp_snippets_json_request_unittest.cc", 141 "remote/ntp_snippets_json_request_unittest.cc",
141 "remote/remote_suggestions_database_unittest.cc", 142 "remote/remote_suggestions_database_unittest.cc",
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 ] 178 ]
178 } 179 }
179 180
180 source_set("test_support") { 181 source_set("test_support") {
181 testonly = true 182 testonly = true
182 sources = [ 183 sources = [
183 "category_rankers/fake_category_ranker.cc", 184 "category_rankers/fake_category_ranker.cc",
184 "category_rankers/fake_category_ranker.h", 185 "category_rankers/fake_category_ranker.h",
185 "category_rankers/mock_category_ranker.cc", 186 "category_rankers/mock_category_ranker.cc",
186 "category_rankers/mock_category_ranker.h", 187 "category_rankers/mock_category_ranker.h",
188 "fake_content_suggestions_provider_observer.cc",
189 "fake_content_suggestions_provider_observer.h",
190 "mock_content_suggestions_provider.cc",
191 "mock_content_suggestions_provider.h",
187 "mock_content_suggestions_provider_observer.cc", 192 "mock_content_suggestions_provider_observer.cc",
188 "mock_content_suggestions_provider_observer.h", 193 "mock_content_suggestions_provider_observer.h",
189 "offline_pages/offline_pages_test_utils.cc", 194 "offline_pages/offline_pages_test_utils.cc",
190 "offline_pages/offline_pages_test_utils.h", 195 "offline_pages/offline_pages_test_utils.h",
191 ] 196 ]
192 197
193 deps = [ 198 deps = [
194 ":ntp_snippets", 199 ":ntp_snippets",
195 "//base", 200 "//base",
196 "//components/offline_pages/core", 201 "//components/offline_pages/core",
197 "//components/offline_pages/core:test_support", 202 "//components/offline_pages/core:test_support",
198 "//testing/gmock", 203 "//testing/gmock",
204 "//testing/gtest",
199 ] 205 ]
200 } 206 }
OLDNEW
« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698