components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc - Issue 2618243004: Add a unit test for the BookmarkSuggestionsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2618243004: Add a unit test for the BookmarkSuggestionsProvider. (Closed)

Patch Set: renamed MockProvider and updated tests comments about expected behavior Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

index 1f8fdf119ba6883e9d99cbc29d0d22119bb1c8b1..0b452a0e165e3ade8e1c8e9fd6efedfa77c21d87 100644

--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

@@ -305,7 +305,6 @@ void BookmarkSuggestionsProvider::FetchBookmarksInternal() {

} else {

end_of_list_last_visit_date_ = suggestions.back().publish_date();

}

observer()->OnNewSuggestions(this, provided_category_,

std::move(suggestions));

}