Animate IOS Share extension button.

Animate IOS Share extension button.

Animation on the share extension is in 3 steps:
- label disappears
- "Added" appears
- a checkmark appears after added.

BUG=676724
Review-Url: https://codereview.chromium.org/2617993002
Cr-Commit-Position: refs/heads/master@{#442207}
Committed: https://chromium.googlesource.com/chromium/src/+/944e00928bdee6bd6961c095cca361586f4a3478

[Olivier, 2017-01-06 15:55:07]

olivierrobin@chromium.org changed reviewers:
+ gambard@chromium.org

[gambard, 2017-01-06 16:23:54]

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
File ios/chrome/share_extension/share_extension_view.mm (right):

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:323: -
(void)animateButtonPressed:(UIButton*)sender
Add method definition and comment.

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:326:
NSLocalizedString(@"IDS_IOS_ADDED_ITEM_SHARE_EXTENSION",
Did you add IDS_IOS_ADDED_ITEM_SHARE_EXTENSION? I don't see it.

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:337: [addedLabel
setTextColor:[sender titleLabel].textColor];
You can use [sender titleColorForState:UIControlStateNormal];

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:338:
[addedLabel.leadingAnchor
This will align the beginning of the "Added" with the previous text of the
button.
Don't we want to center it?
You will need to change the way you are doing step3 if you do like that.

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:353: completion();
You don't check for nullability?

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:380: -
(void)addToBookmarksPressed:(UIButton*)sender {
Please position this function before animateButtonPressed:withCompletion:

[Olivier, 2017-01-06 16:42:16]

Thanks.
PTAL

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
File ios/chrome/share_extension/share_extension_view.mm (right):

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:323: -
(void)animateButtonPressed:(UIButton*)sender
On 2017/01/06 16:23:54, gambard wrote:
> Add method definition and comment.

Done.

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:326:
NSLocalizedString(@"IDS_IOS_ADDED_ITEM_SHARE_EXTENSION",
On 2017/01/06 16:23:54, gambard wrote:
> Did you add IDS_IOS_ADDED_ITEM_SHARE_EXTENSION? I don't see it.

I did... in another tree... :(

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:337: [addedLabel
setTextColor:[sender titleLabel].textColor];
On 2017/01/06 16:23:54, gambard wrote:
> You can use [sender titleColorForState:UIControlStateNormal];

Done.

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:338:
[addedLabel.leadingAnchor
On 2017/01/06 16:23:54, gambard wrote:
> This will align the beginning of the "Added" with the previous text of the
> button.
> Don't we want to center it?
> You will need to change the way you are doing step3 if you do like that.

There is no mock on what is centered.
What is true is that both labels must be aligned by leading as text of the
second must be just over the text of the first.

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:353: completion();
On 2017/01/06 16:23:54, gambard wrote:
> You don't check for nullability?

Done.

https://codereview.chromium.org/2617993002/diff/40001/ios/chrome/share_extens...
ios/chrome/share_extension/share_extension_view.mm:380: -
(void)addToBookmarksPressed:(UIButton*)sender {
On 2017/01/06 16:23:54, gambard wrote:
> Please position this function before animateButtonPressed:withCompletion:

Done.

[gambard, 2017-01-09 08:03:46]

lgtm

[Olivier, 2017-01-09 08:04:20]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-01-09 08:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 08:13:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483949060085580,
"parent_rev": "1a64a69aa334a8cafcbffd75a7af0841be1285b0", "commit_rev":
"944e00928bdee6bd6961c095cca361586f4a3478"}

[commit-bot: I haz the power, 2017-01-09 08:13:46]

Description was changed from

==========
Animate IOS Share extension button.

Animation on the share extension is in 3 steps:
- label disappears
- "Added" appears
- a checkmark appears after added.

BUG=676724
==========

to

==========
Animate IOS Share extension button.

Animation on the share extension is in 3 steps:
- label disappears
- "Added" appears
- a checkmark appears after added.

BUG=676724

Review-Url: https://codereview.chromium.org/2617993002
Cr-Commit-Position: refs/heads/master@{#442207}
Committed:
https://chromium.googlesource.com/chromium/src/+/944e00928bdee6bd6961c095cca3...
==========

[commit-bot: I haz the power, 2017-01-09 08:13:47]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/944e00928bdee6bd6961c095cca3...