Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/share_extension/share_view_controller.mm

Issue 2617993002: Animate IOS Share extension button. (Closed)
Patch Set: feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/share_extension/share_view_controller.mm
diff --git a/ios/chrome/share_extension/share_view_controller.mm b/ios/chrome/share_extension/share_view_controller.mm
index 9ba8972adaea203d73255e0f28071c5ad55760c9..31f0d4063456589cd3ee7d602847e633f0c009d7 100644
--- a/ios/chrome/share_extension/share_view_controller.mm
+++ b/ios/chrome/share_extension/share_view_controller.mm
@@ -28,7 +28,6 @@ const CGFloat kShareExtensionMaxWidth = 390;
// Clip the last separator out of the table view.
const CGFloat kScreenShotWidth = 100;
const CGFloat kScreenShotHeight = 100;
-const CGFloat kAnimationDuration = 0.3;
const CGFloat kMediumAlpha = 0.5;
} // namespace
@@ -130,7 +129,7 @@ const CGFloat kMediumAlpha = 0.5;
constraintEqualToAnchor:self.view.centerYAnchor];
[_widgetVerticalPlacementConstraint setActive:YES];
[self.maskView setAlpha:0];
- [UIView animateWithDuration:kAnimationDuration
+ [UIView animateWithDuration:ui_util::kAnimationDuration
animations:^{
[self.maskView setAlpha:1];
[self.view layoutIfNeeded];
@@ -254,7 +253,7 @@ const CGFloat kMediumAlpha = 0.5;
[_shareView.topAnchor constraintEqualToAnchor:self.view.bottomAnchor];
}
[_widgetVerticalPlacementConstraint setActive:YES];
- [UIView animateWithDuration:kAnimationDuration
+ [UIView animateWithDuration:ui_util::kAnimationDuration
animations:^{
[self.maskView setAlpha:0];
[self.view layoutIfNeeded];
« no previous file with comments | « ios/chrome/share_extension/share_extension_view.mm ('k') | ios/chrome/share_extension/strings/ios_share_extension_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698