Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 2617763002: Revert of Don't post multiple task for executing blocked scripts. (Closed)

Created:
3 years, 11 months ago by rune
Modified:
3 years, 11 months ago
Reviewers:
Pat Meenan
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't post multiple task for executing blocked scripts. (patchset #2 id:20001 of https://codereview.chromium.org/2609763002/ ) Reason for revert: Regression in test for time to first meaningful paint: https://crbug.com/678584 Original issue's description: > Don't post multiple task for executing blocked scripts. > > We may post a lot of tasks for executing blocked scripts in the case > where we insert multiple shadow trees each containing a style element. > When we start parsing a style element, we mark it as blocking and > unblock script execution after finishing parsing. Check if the previous > task is active before posting. > > Found while measuring performance for issue 603621. > > BUG=603621 > > Committed: https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0 > Cr-Commit-Position: refs/heads/master@{#441110} TBR=pmeenan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603621 Review-Url: https://codereview.chromium.org/2617763002 Cr-Commit-Position: refs/heads/master@{#441783} Committed: https://chromium.googlesource.com/chromium/src/+/482c1f85b922eeec0b9525838baca4b884c27392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rune
Created Revert of Don't post multiple task for executing blocked scripts.
3 years, 11 months ago (2017-01-05 20:42:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617763002/1
3 years, 11 months ago (2017-01-05 20:43:22 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:21:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/482c1f85b922eeec0b9525838bac...

Powered by Google App Engine
This is Rietveld 408576698