Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2609763002: Don't post multiple task for executing blocked scripts. (Closed)

Created:
3 years, 11 months ago by rune
Modified:
3 years, 11 months ago
Reviewers:
Pat Meenan
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't post multiple task for executing blocked scripts. We may post a lot of tasks for executing blocked scripts in the case where we insert multiple shadow trees each containing a style element. When we start parsing a style element, we mark it as blocking and unblock script execution after finishing parsing. Check if the previous task is active before posting. Found while measuring performance for issue 603621. BUG=603621 Committed: https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0 Cr-Commit-Position: refs/heads/master@{#441110}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
rune
ptal
3 years, 11 months ago (2017-01-03 11:52:15 UTC) #6
Pat Meenan
lgtm
3 years, 11 months ago (2017-01-03 13:03:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609763002/20001
3 years, 11 months ago (2017-01-03 13:25:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 13:29:47 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0 Cr-Commit-Position: refs/heads/master@{#441110}
3 years, 11 months ago (2017-01-03 13:32:38 UTC) #18
rune
3 years, 11 months ago (2017-01-05 20:42:37 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2617763002/ by rune@opera.com.

The reason for reverting is: Regression in test for time to first meaningful
paint: https://crbug.com/678584
.

Powered by Google App Engine
This is Rietveld 408576698