Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2617633003: [Devtools] Removed timeline setting from network log settings (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Devtools] Removed timeline setting from network log settings This patch ensures there are no lingering "timeline" setting for network log settings. "timeline" or "waterfall" may have been saved into the users settings and when the new waterfall came out it may have caused some users to see "timeline" as a custom column; this removes that. R=dgozman BUG=666472 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2513733002 Cr-Commit-Position: refs/heads/master@{#433091} (cherry picked from commit ff55f920752fe080a09137e51dd1f14d0a5018a3) Review-Url: https://codereview.chromium.org/2617633003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/common/Settings.js View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
pfeldman
lgtm
3 years, 11 months ago (2017-01-05 02:49:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617633003/1
3 years, 11 months ago (2017-01-05 02:51:29 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago (2017-01-05 02:51:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617633003/1
3 years, 11 months ago (2017-01-05 03:03:23 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 03:07:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698