Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2513733002: [Devtools] Removed timeline setting from network log settings (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Removed timeline setting from network log settings This patch ensures there are no lingering "timeline" setting for network log settings. "timeline" or "waterfall" may have been saved into the users settings and when the new waterfall came out it may have caused some users to see "timeline" as a custom column; this removes that. R=dgozman,lushnikov BUG=666472 Committed: https://crrev.com/ff55f920752fe080a09137e51dd1f14d0a5018a3 Cr-Commit-Position: refs/heads/master@{#433091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/common/Settings.js View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
allada
PTL
4 years, 1 month ago (2016-11-17 21:36:23 UTC) #2
dgozman
lgtm
4 years, 1 month ago (2016-11-17 21:49:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513733002/1
4 years, 1 month ago (2016-11-18 01:36:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 04:14:21 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:18:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff55f920752fe080a09137e51dd1f14d0a5018a3
Cr-Commit-Position: refs/heads/master@{#433091}

Powered by Google App Engine
This is Rietveld 408576698