Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2617603003: Merge //ios/chrome/browser/ui:ui_arc with //ios/chrome/browser/ui. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org, stkhapugin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge //ios/chrome/browser/ui:ui_arc with //ios/chrome/browser/ui. Since both targets require ARC and //ios/chrome/browser/ui has a public_deps on //ios/chrome/browser/ui:ui_arc, the separation is no longer necessary. BUG=624363 Review-Url: https://codereview.chromium.org/2617603003 Cr-Commit-Position: refs/heads/master@{#441756} Committed: https://chromium.googlesource.com/chromium/src/+/8fd3bd6a236776370e8c8fc9562d279b6cd9fbc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 3 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sdefresne
lpromero: Please take a look. stkhapugin: FYI
3 years, 11 months ago (2017-01-05 17:34:39 UTC) #3
lpromero
lgtm
3 years, 11 months ago (2017-01-05 21:10:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617603003/1
3 years, 11 months ago (2017-01-05 21:10:59 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 21:21:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8fd3bd6a236776370e8c8fc9562d...

Powered by Google App Engine
This is Rietveld 408576698