Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/BUILD.gn

Issue 2617603003: Merge //ios/chrome/browser/ui:ui_arc with //ios/chrome/browser/ui. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/BUILD.gn
diff --git a/ios/chrome/browser/ui/BUILD.gn b/ios/chrome/browser/ui/BUILD.gn
index 0b35f535c2e41312c8576be221ed3f56afd3ba46..bc0f3a7b10b8978718aa76e0ad809d811e2623f0 100644
--- a/ios/chrome/browser/ui/BUILD.gn
+++ b/ios/chrome/browser/ui/BUILD.gn
@@ -4,19 +4,7 @@
import("//build/config/ios/rules.gni")
-source_set("ui_arc") {
- sources = [
- "network_activity_indicator_manager.h",
- "network_activity_indicator_manager.mm",
- ]
- deps = [
- "//base",
- ]
- configs += [ "//build/config/compiler:enable_arc" ]
-}
-
source_set("ui") {
- configs += [ "//build/config/compiler:enable_arc" ]
sources = [
"UIView+SizeClassSupport.h",
"UIView+SizeClassSupport.mm",
@@ -32,6 +20,8 @@ source_set("ui") {
"image_util.mm",
"native_content_controller.h",
"native_content_controller.mm",
+ "network_activity_indicator_manager.h",
+ "network_activity_indicator_manager.mm",
"orientation_limiting_navigation_controller.h",
"orientation_limiting_navigation_controller.mm",
"prerender_final_status.h",
@@ -61,18 +51,13 @@ source_set("ui") {
"//ui/base",
"//ui/gfx",
]
- public_deps = [
- ":ui_arc",
- ]
- allow_circular_includes_from = [
- ":ui_arc",
- "//ios/chrome/browser/ui/commands",
- ]
+ allow_circular_includes_from = [ "//ios/chrome/browser/ui/commands" ]
libs = [
"Accelerate.framework",
"CoreGraphics.framework",
"QuartzCore.framework",
]
+ configs += [ "//build/config/compiler:enable_arc" ]
}
source_set("unit_tests") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698