Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2617603002: Revert of Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content. (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content. (patchset #6 id:100001 of https://codereview.chromium.org/2580063002/ ) Reason for revert: This appears to have broken mus ws unittests: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19757 It's the only mus-related change in the list. Speculatively reverting. Original issue's description: > Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content. > > - Use SurfaceLayers in embedders and Window Manager to properly position the > embedded content in the layer tree. > > - WM no longer uses underlay surfaces for window decorations. Instead they are > submitted to Mus as part of the WM's surface. > > - FrameGenerator now only creates SurfaceDrawQuad for the top-level window > rather than recursively creating SurfaceDrawQuad for all windows in the > window tree, since all surfaces are now part of the tree rooted at the > surface of the top-level window. > > BUG=672943, 669964 > > Committed: https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb > Cr-Commit-Position: refs/heads/master@{#441492} TBR=sky@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,mfomitchev@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672943, 669964 Committed: https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682 Cr-Commit-Position: refs/heads/master@{#441522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -226 lines) Patch
M services/ui/ws/display.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/display.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M services/ui/ws/frame_generator.h View 1 chunk +6 lines, -3 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 2 chunks +64 lines, -24 lines 0 comments Download
M services/ui/ws/frame_generator_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 3 chunks +40 lines, -12 lines 0 comments Download
M services/ui/ws/platform_display_default.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/platform_display_default.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/platform_display_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/ws/test_utils.h View 1 chunk +1 line, -4 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/aura/mus/client_surface_embedder.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/aura/mus/client_surface_embedder.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Devlin
3 years, 11 months ago (2017-01-05 00:02:57 UTC) #2
Created Revert of Mustash: Ensure surfaces submitted to Mus by WM and embedders
contain Surfaces with embeded content.

Powered by Google App Engine
This is Rietveld 408576698