Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2617453002:
Support --js-flags via --extra-browser-args in WebGL conformance tests. (Closed)
|
Created:
3 years, 11 months ago by Ken Russell (switch to Gerrit) Modified:
3 years, 11 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, nednguyen, eyaich1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport --js-flags via --extra-browser-args in WebGL conformance tests.
It's impractical to merge them, so instead, allow overriding them.
Tested manually on Windows.
BUG=675582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/25da6356a3246812d79aaedcb236e1545ed88c95
Cr-Commit-Position: refs/heads/master@{#441410}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Support --js-flags via --extra-browser-args in WebGL conformance tests. It's impractical to merge them, so instead, allow overriding them. Tested manually on Windows. BUG=675582 ========== to ========== Support --js-flags via --extra-browser-args in WebGL conformance tests. It's impractical to merge them, so instead, allow overriding them. Tested manually on Windows. BUG=675582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + kainino@chromium.org, zmo@chromium.org
Mo or Kai: could you please review this? Michael: could you please patch this in to your local workspace and verify it does what you want when running the WebGL conformance tests? I tested it locally and it works, but want to make sure it handles your uses. Ned and Emily: FYI only.
The CQ bit was checked by kbr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/01/04 06:20:44, Ken Russell wrote: > Michael: could you please patch this in to your local workspace and verify it > does what you want when running the WebGL conformance tests? I tested it locally > and it works, but want to make sure it handles your uses. > Works like a charm, thanks! (Checked on Win)
On 2017/01/04 14:25:21, Michael Lippautz wrote: > On 2017/01/04 06:20:44, Ken Russell wrote: > > Michael: could you please patch this in to your local workspace and verify it > > does what you want when running the WebGL conformance tests? I tested it > locally > > and it works, but want to make sure it handles your uses. > > > > Works like a charm, thanks! (Checked on Win) lgtm
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483553464438630, "parent_rev":
"d77ef21c3e3ee36defcdeec8a1a0e494cd49a3bb", "commit_rev":
"6090b3ec40a503cc8e2b79dfb32a6123c23e9155"}
Message was sent while issue was closed.
Description was changed from ========== Support --js-flags via --extra-browser-args in WebGL conformance tests. It's impractical to merge them, so instead, allow overriding them. Tested manually on Windows. BUG=675582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Support --js-flags via --extra-browser-args in WebGL conformance tests. It's impractical to merge them, so instead, allow overriding them. Tested manually on Windows. BUG=675582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2617453002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Support --js-flags via --extra-browser-args in WebGL conformance tests. It's impractical to merge them, so instead, allow overriding them. Tested manually on Windows. BUG=675582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2617453002 ========== to ========== Support --js-flags via --extra-browser-args in WebGL conformance tests. It's impractical to merge them, so instead, allow overriding them. Tested manually on Windows. BUG=675582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/25da6356a3246812d79aaedcb236e1545ed88c95 Cr-Commit-Position: refs/heads/master@{#441410} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/25da6356a3246812d79aaedcb236e1545ed88c95 Cr-Commit-Position: refs/heads/master@{#441410} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
