Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance_integration_test.py

Issue 2617453002: Support --js-flags via --extra-browser-args in WebGL conformance tests. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py b/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
index 6048e4d399a7cf88efa8eacd81e500251a4f25a9..e5df9e18c6d2a71df13724338cc9e9cfc1991dd0 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import logging
import os
from gpu_tests import gpu_integration_test
@@ -250,7 +251,6 @@ class WebGLConformanceIntegrationTest(gpu_integration_test.GpuIntegrationTest):
'--disable-gesture-requirement-for-media-playback',
'--disable-domain-blocking-for-3d-apis',
'--disable-gpu-process-crash-limit',
- '--js-flags=--expose-gc',
'--test-type=gpu',
'--enable-experimental-canvas-features',
# Try disabling the GPU watchdog to see if this affects the
@@ -258,6 +258,23 @@ class WebGLConformanceIntegrationTest(gpu_integration_test.GpuIntegrationTest):
# waterfall. crbug.com/596622 crbug.com/609252
'--disable-gpu-watchdog'
])
+
+ builtin_js_flags = '--js-flags=--expose-gc'
+ found_js_flags = False
+ user_js_flags = ''
+ if browser_options.extra_browser_args:
+ for o in browser_options.extra_browser_args:
+ if o.startswith('--js-flags'):
+ found_js_flags = True
+ user_js_flags = o
+ break
+ if found_js_flags:
+ logging.warning('Overriding built-in JavaScript flags:')
+ logging.warning(' Original flags: ' + builtin_js_flags)
+ logging.warning(' New flags: ' + user_js_flags)
+ else:
+ browser_options.AppendExtraBrowserArgs([builtin_js_flags])
+
if cls._webgl_version == 2:
browser_options.AppendExtraBrowserArgs([
'--enable-es3-apis',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698