Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2617443005: Implements CSSPropertyAPI for the font-size-adjust property. (Closed)

Created:
3 years, 11 months ago by aazzam
Modified:
3 years, 11 months ago
Reviewers:
sashab, Bugs Nash
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements CSSPropertyAPI for the font-size-adjust property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyFontSizeAdjust from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIFontSizeAdjust.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIFontSizeAdjust.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIFontSizeAdjust.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2617443005 Cr-Commit-Position: refs/heads/master@{#442814} Committed: https://chromium.googlesource.com/chromium/src/+/7995bd5611577493e9a73d32b32666ac6cc031d8

Patch Set 1 #

Patch Set 2 : fixed dependencies, changed year #

Patch Set 3 : fixed dependencies, changed year #

Total comments: 3

Patch Set 4 : dependencies #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 2 chunks +0 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 31 (24 generated)
aazzam
3 years, 11 months ago (2017-01-05 04:14:40 UTC) #2
Bugs Nash
https://codereview.chromium.org/2617443005/diff/40001/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp (right): https://codereview.chromium.org/2617443005/diff/40001/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp#newcode7 third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp:7: #include "core/css/CSSValueList.h" not needed https://codereview.chromium.org/2617443005/diff/40001/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp#newcode8 third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp:8: #include "core/css/parser/CSSParserContext.h" can ...
3 years, 11 months ago (2017-01-05 23:02:33 UTC) #4
aazzam
3 years, 11 months ago (2017-01-08 02:48:48 UTC) #7
Bugs Nash
lgtm
3 years, 11 months ago (2017-01-08 20:14:01 UTC) #8
sashab
lgtm
3 years, 11 months ago (2017-01-09 03:35:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617443005/120001
3 years, 11 months ago (2017-01-11 05:32:46 UTC) #28
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 05:37:07 UTC) #31
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7995bd5611577493e9a73d32b326...

Powered by Google App Engine
This is Rietveld 408576698