Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2613843002: Implements CSSPropertyAPI for the flex-basis property. (Closed)

Created:
3 years, 11 months ago by aazzam
Modified:
3 years, 11 months ago
Reviewers:
meade_UTC10, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements CSSPropertyAPI for the flex-basis property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyFlexBasis from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIFlexBasis.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIFlexBasis.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIFlexBasis.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2613843002 Cr-Commit-Position: refs/heads/master@{#442815} Committed: https://chromium.googlesource.com/chromium/src/+/06d4b710f141515835cd08440b66a59914566b39

Patch Set 1 #

Patch Set 2 : fixed dependencies, changed year #

Patch Set 3 : dependencies #

Patch Set 4 : upstream #

Patch Set 5 : upstream #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 2 chunks +0 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexBasis.cpp View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 30 (24 generated)
aazzam
3 years, 11 months ago (2017-01-05 04:01:31 UTC) #2
meade_UTC10
lgtm
3 years, 11 months ago (2017-01-05 04:12:26 UTC) #3
aazzam
3 years, 11 months ago (2017-01-08 02:49:53 UTC) #7
sashab
lgtm
3 years, 11 months ago (2017-01-09 05:11:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613843002/140001
3 years, 11 months ago (2017-01-11 05:37:54 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 05:43:17 UTC) #30
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/06d4b710f141515835cd08440b66...

Powered by Google App Engine
This is Rietveld 408576698