Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 2617403003: Mus: Remove CompositorFrameSinkType (Closed)

Created:
3 years, 11 months ago by Fady Samuel
Modified:
3 years, 10 months ago
Reviewers:
Tom Sepez, sky, Wez
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: Remove CompositorFrameSinkType Now that underlay surfaces are gone, there is no reason to have a CompositorFrameSinkType in Mus. BUG=672943 Review-Url: https://codereview.chromium.org/2617403003 Cr-Commit-Position: refs/heads/master@{#442675} Committed: https://chromium.googlesource.com/chromium/src/+/ec78ec0763a819fc5d5f346bef3538ff090368a5

Patch Set 1 #

Patch Set 2 : Remove remaining CompositorFrameSinkType #

Total comments: 2

Patch Set 3 : Remove unnecessary include #

Patch Set 4 : Remove unnecessary include and rebase #

Patch Set 5 : Fix some unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -227 lines) Patch
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/window.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/public/cpp/window.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M services/ui/public/interfaces/window_tree.mojom View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/interfaces/window_tree_constants.mojom View 1 1 chunk +0 lines, -17 lines 0 comments Download
M services/ui/ws/access_policy.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/default_access_policy.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/default_access_policy.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 2 3 3 chunks +6 lines, -15 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 1 1 chunk +4 lines, -9 lines 0 comments Download
M services/ui/ws/server_window.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/server_window.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 1 2 3 6 chunks +8 lines, -27 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 2 3 4 2 chunks +49 lines, -76 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager_test_api.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M services/ui/ws/window_finder.cc View 1 chunk +1 line, -4 lines 0 comments Download
M services/ui/ws/window_manager_access_policy.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M services/ui/ws/window_manager_access_policy.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 3 chunks +3 lines, -9 lines 0 comments Download
M services/ui/ws/window_server_test_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_tree.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/mus/mus_context_factory.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/window_port_mus.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/test/mus/test_window_tree.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 29 (20 generated)
Fady Samuel
PTAL Scott!
3 years, 11 months ago (2017-01-09 17:50:31 UTC) #9
sky
LGTM https://codereview.chromium.org/2617403003/diff/20001/services/ui/ws/server_window_compositor_frame_sink_manager.h File services/ui/ws/server_window_compositor_frame_sink_manager.h (right): https://codereview.chromium.org/2617403003/diff/20001/services/ui/ws/server_window_compositor_frame_sink_manager.h#newcode8 services/ui/ws/server_window_compositor_frame_sink_manager.h:8: #include <map> remove include?
3 years, 11 months ago (2017-01-09 19:03:00 UTC) #12
Fady Samuel
Thanks, CQ'ing. https://codereview.chromium.org/2617403003/diff/20001/services/ui/ws/server_window_compositor_frame_sink_manager.h File services/ui/ws/server_window_compositor_frame_sink_manager.h (right): https://codereview.chromium.org/2617403003/diff/20001/services/ui/ws/server_window_compositor_frame_sink_manager.h#newcode8 services/ui/ws/server_window_compositor_frame_sink_manager.h:8: #include <map> On 2017/01/09 19:03:00, sky wrote: ...
3 years, 11 months ago (2017-01-09 19:27:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617403003/40001
3 years, 11 months ago (2017-01-09 19:28:41 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/299301)
3 years, 11 months ago (2017-01-09 20:20:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617403003/60001
3 years, 11 months ago (2017-01-10 18:46:13 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617403003/80001
3 years, 11 months ago (2017-01-10 19:05:49 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/ec78ec0763a819fc5d5f346bef3538ff090368a5
3 years, 11 months ago (2017-01-10 20:36:36 UTC) #27
Wez
3 years, 10 months ago (2017-02-07 02:30:00 UTC) #29
Message was sent while issue was closed.
Hallo tsepez@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	services/ui/public/interfaces/window_tree.mojom
	services/ui/public/interfaces/window_tree_constants.mojom
Thanks,
Wez

Powered by Google App Engine
This is Rietveld 408576698