Mus: Remove CompositorFrameSinkType

services/ui/ws/server_window_compositor_frame_sink_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_UI_WS_SERVER_WINDOW_COMPOSITOR_FRAME_SINK_MANAGER_H_
 #define SERVICES_UI_WS_SERVER_WINDOW_COMPOSITOR_FRAME_SINK_MANAGER_H_
 
 #include <map>

[sky, 2017/01/09 19:03:00]

remove include?

[Fady Samuel, 2017/01/09 19:27:57]

Done.

 
 #include "base/macros.h"
 #include "cc/ipc/compositor_frame.mojom.h"
 #include "cc/ipc/display_compositor.mojom.h"
 #include "cc/output/context_provider.h"
 #include "cc/surfaces/surface_id.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "services/ui/public/interfaces/window_tree.mojom.h"
 
 namespace ui {
@@ skipping 12 matching lines @@
 
   cc::SurfaceInfo latest_submitted_surface_info;
   cc::mojom::MojoCompositorFrameSinkPrivatePtr compositor_frame_sink;
   cc::mojom::MojoCompositorFrameSinkPrivateRequest
       pending_compositor_frame_sink_request;
   cc::FrameSinkId frame_sink_id;
 };
 
 // ServerWindowCompositorFrameSinkManager tracks the surfaces associated with a
 // ServerWindow.
-// TODO(fsamuel): Delete this once window decorations are managed in the window
-// manager.
 class ServerWindowCompositorFrameSinkManager {
  public:
   explicit ServerWindowCompositorFrameSinkManager(ServerWindow* window);
   ~ServerWindowCompositorFrameSinkManager();
 
-  // Returns true if the CompositorFrameSinks from this manager should be drawn.
-  bool ShouldDraw();
-
   // Creates a new CompositorFrameSink of the specified type, replacing the
   // existing one of the specified type.
   void CreateDisplayCompositorFrameSink(
       gfx::AcceleratedWidget widget,
       cc::mojom::MojoCompositorFrameSinkRequest request,
       cc::mojom::MojoCompositorFrameSinkClientPtr client,
       cc::mojom::DisplayPrivateRequest display_private_request);
+
   void CreateOffscreenCompositorFrameSink(
-      mojom::CompositorFrameSinkType compositor_frame_sink_type,
       cc::mojom::MojoCompositorFrameSinkRequest request,
       cc::mojom::MojoCompositorFrameSinkClientPtr client);
 
   // Adds the provided |frame_sink_id| to this ServerWindow's associated
   // CompositorFrameSink if possible. If this ServerWindow does not have
   // an associated CompositorFrameSink then this method will recursively
   // walk up the window hierarchy and register itself with the first ancestor
   // that has a CompositorFrameSink of the same type. This method returns
   // the FrameSinkId that is the first composited ancestor of the ServerWindow
   // assocaited with the provided |frame_sink_id|.
-  void AddChildFrameSinkId(
-      mojom::CompositorFrameSinkType compositor_frame_sink_type,
-      const cc::FrameSinkId& frame_sink_id);
-  void RemoveChildFrameSinkId(
-      mojom::CompositorFrameSinkType compositor_frame_sink_type,
-      const cc::FrameSinkId& frame_sink_id);
+  void AddChildFrameSinkId(const cc::FrameSinkId& frame_sink_id);
+  void RemoveChildFrameSinkId(const cc::FrameSinkId& frame_sink_id);
 
   ServerWindow* window() { return window_; }
 
-  bool HasCompositorFrameSinkOfType(mojom::CompositorFrameSinkType type) const;
-  bool HasAnyCompositorFrameSink() const;
+  bool HasCompositorFrameSink() const;
 
-  gfx::Size GetLatestFrameSize(mojom::CompositorFrameSinkType type) const;
-  cc::SurfaceId GetLatestSurfaceId(mojom::CompositorFrameSinkType type) const;
-  void SetLatestSurfaceInfo(mojom::CompositorFrameSinkType type,
-                            const cc::SurfaceInfo& surface_info);
+  gfx::Size GetLatestFrameSize() const;
+  cc::SurfaceId GetLatestSurfaceId() const;
+  void SetLatestSurfaceInfo(const cc::SurfaceInfo& surface_info);
 
   void OnRootChanged(ServerWindow* old_root, ServerWindow* new_root);
 
  private:
   friend class ServerWindowCompositorFrameSinkManagerTestApi;
   friend class ServerWindowCompositorFrameSink;
 
-  // Returns true if a CompositorFrameSink of |type| has been set and has
-  // received a frame that is greater than the size of the window.
-  bool IsCompositorFrameSinkReadyAndNonEmpty(
-      mojom::CompositorFrameSinkType type) const;
-
   void CreateCompositorFrameSinkInternal(
-      mojom::CompositorFrameSinkType compositor_frame_sink_type,
       gfx::AcceleratedWidget widget,
       cc::mojom::MojoCompositorFrameSinkRequest request,
       cc::mojom::MojoCompositorFrameSinkClientPtr client,
       cc::mojom::DisplayPrivateRequest display_private_request);
 
   ServerWindow* window_;
 
-  using TypeToCompositorFrameSinkMap =
-      std::map<mojom::CompositorFrameSinkType, CompositorFrameSinkData>;
-
-  TypeToCompositorFrameSinkMap type_to_compositor_frame_sink_map_;
-
-  // TODO(mfomitchev): This is currently always false. Confirm if we still need
-  // this.
-  // While true the window is not drawn. This is initially true if the window
-  // has the property |kWaitForUnderlay_Property|. This is set to false once
-  // the underlay and default surface have been set *and* their size is at
-  // least that of the window. Ideally we would wait for sizes to match, but
-  // the underlay is not necessarily as big as the window.
-  bool waiting_for_initial_frames_;
+  std::unique_ptr<CompositorFrameSinkData> frame_sink_data_;
 
   DISALLOW_COPY_AND_ASSIGN(ServerWindowCompositorFrameSinkManager);
 };
 
 }  // namespace ws
 }  // namespace ui
 
 #endif  // SERVICES_UI_WS_SERVER_WINDOW_COMPOSITOR_FRAME_SINK_MANAGER_H_