Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2617393004: Remove marking visitors' shouldMarkObject(). (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove marking visitors' shouldMarkObject(). With per-thread heap handling being fully enabled, checking for any cross-thread pointer marking (and not doing it), is no longer an issue. Retire the should-mark predicate. R=haraken BUG=671856 Review-Url: https://codereview.chromium.org/2617393004 Cr-Commit-Position: refs/heads/master@{#442554} Committed: https://chromium.googlesource.com/chromium/src/+/3e4032bc598ae10eeb99036e383ca2f63b73bd1a

Patch Set 1 #

Patch Set 2 : reinstate same-thread dcheck for ensureMarked() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -30 lines) Patch
M third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitor.h View 2 chunks +1 line, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-10 09:58:38 UTC) #7
haraken
LGTM
3 years, 11 months ago (2017-01-10 10:46:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617393004/20001
3 years, 11 months ago (2017-01-10 11:58:25 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 12:03:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e4032bc598ae10eeb99036e383c...

Powered by Google App Engine
This is Rietveld 408576698