Remove marking visitors' shouldMarkObject().

third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MarkingVisitorImpl_h
 #define MarkingVisitorImpl_h
 
 #include "platform/heap/Heap.h"
 #include "platform/heap/ThreadState.h"
 #include "platform/heap/Visitor.h"
 #include "wtf/Allocator.h"
 
 namespace blink {
 
 template <typename Derived>
 class MarkingVisitorImpl {
   USING_FAST_MALLOC(MarkingVisitorImpl);
 
  protected:
   inline void markHeader(HeapObjectHeader* header,
                          const void* objectPointer,
                          TraceCallback callback) {
     ASSERT(header);
     ASSERT(objectPointer);
-    if (!toDerived()->shouldMarkObject(objectPointer))
-      return;
 
     // If you hit this ASSERT, it means that there is a dangling pointer
     // from a live thread heap to a dead thread heap.  We must eliminate
     // the dangling pointer.
     // Release builds don't have the ASSERT, but it is OK because
     // release builds will crash in the following header->isMarked()
     // because all the entries of the orphaned arenas are zapped.
     ASSERT(!pageFromObject(objectPointer)->orphaned());
 
     if (header->isMarked())
@@ skipping 62 matching lines @@
                                            void* callbackData) {
     if (toDerived()->getMarkingMode() != Visitor::GlobalMarkingWithCompaction)
       return;
     toDerived()->heap().registerMovingObjectCallback(reference, callback,
                                                      callbackData);
   }
 
   inline bool ensureMarked(const void* objectPointer) {
     if (!objectPointer)
       return false;
-    if (!toDerived()->shouldMarkObject(objectPointer))
+
+    HeapObjectHeader* header = HeapObjectHeader::fromPayload(objectPointer);
+    if (header->isMarked())
       return false;
 #if ENABLE(ASSERT)
-    if (HeapObjectHeader::fromPayload(objectPointer)->isMarked())
-      return false;
-
     toDerived()->markNoTracing(objectPointer);
 #else
     // Inline what the above markNoTracing() call expands to,
-    // so as to make sure that we do get all the benefits.
-    HeapObjectHeader* header = HeapObjectHeader::fromPayload(objectPointer);
-    if (header->isMarked())
-      return false;
+    // so as to make sure that we do get all the benefits (asserts excepted.)
     header->mark();
 #endif
     return true;
   }
 
   inline void registerWeakCellWithCallback(void** cell, WeakCallback callback) {
     ASSERT(toDerived()->getMarkingMode() != Visitor::WeakProcessing);
     // We don't want to run weak processings when taking a snapshot.
     if (toDerived()->getMarkingMode() == Visitor::SnapshotMarking)
       return;
     toDerived()->heap().pushGlobalWeakCallback(cell, callback);
   }
 
   Derived* toDerived() { return static_cast<Derived*>(this); }
 
  private:
   static void markNoTracingCallback(Visitor* visitor, void* object) {
     visitor->markNoTracing(object);
   }
 };
 
 }  // namespace blink
 
 #endif