Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2617363005: Expand code that syncs ToS-seen prefs on Android. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Expand code that syncs ToS-seen prefs on Android. With this change, this code will set both the Java and native side prefs if any of the three indicators of TOS being seen are true, i.e. either of the two prefs or "any user has seen ToS". This is especially needed to fix variations seed fetching from native code in the case of Backup & Restore, which does not appear to restore the Chrome native pref. BUG=669543 Review-Url: https://codereview.chromium.org/2614183002 Cr-Commit-Position: refs/heads/master@{#442065} (cherry picked from commit a82983afecb4762005ac0d57809c55382aa6d1dd) Review-Url: https://codereview.chromium.org/2617363005 . Cr-Commit-Position: refs/branch-heads/2924@{#706} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/b451bcfd3e7671196c7679118e02df98eb3dcf25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java View 1 chunk +18 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexei Svitkine (slow)
3 years, 11 months ago (2017-01-09 20:26:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b451bcfd3e7671196c7679118e02df98eb3dcf25.

Powered by Google App Engine
This is Rietveld 408576698