Expand code that syncs ToS-seen prefs on Android.

Expand code that syncs ToS-seen prefs on Android.

With this change, this code will set both the Java and native side
prefs if any of the three indicators of TOS being seen are true,
i.e. either of the two prefs or "any user has seen ToS".

This is especially needed to fix variations seed fetching from
native code in the case of Backup & Restore, which does not
appear to restore the Chrome native pref.

BUG=669543
Review-Url: https://codereview.chromium.org/2614183002
Cr-Commit-Position: refs/heads/master@{#442065}
Committed: https://chromium.googlesource.com/chromium/src/+/a82983afecb4762005ac0d57809c55382aa6d1dd

[Alexei Svitkine (slow), 2017-01-06 20:12:03]

asvitkine@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Alexei Svitkine (slow), 2017-01-06 20:16:51]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 20:17:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:51:00]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-01-06 21:30:56]

lgtm

[Alexei Svitkine (slow), 2017-01-06 21:44:00]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:44:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:50:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483739040649370, "parent_rev":
"9276998c3811db276e04aff731b8aebfdae8ce71", "commit_rev":
"a82983afecb4762005ac0d57809c55382aa6d1dd"}

[commit-bot: I haz the power, 2017-01-06 21:50:58]

Description was changed from

==========
Expand code that syncs ToS-seen prefs on Android.

With this change, this code will set both the Java and native side
prefs if any of the three indicators of TOS being seen are true,
i.e. either of the two prefs or "any user has seen ToS".

This is especially needed to fix variations seed fetching from
native code in the case of Backup & Restore, which does not
appear to restore the Chrome native pref.

BUG=669543
==========

to

==========
Expand code that syncs ToS-seen prefs on Android.

With this change, this code will set both the Java and native side
prefs if any of the three indicators of TOS being seen are true,
i.e. either of the two prefs or "any user has seen ToS".

This is especially needed to fix variations seed fetching from
native code in the case of Backup & Restore, which does not
appear to restore the Chrome native pref.

BUG=669543

Review-Url: https://codereview.chromium.org/2614183002
Cr-Commit-Position: refs/heads/master@{#442065}
Committed:
https://chromium.googlesource.com/chromium/src/+/a82983afecb4762005ac0d57809c...
==========

[commit-bot: I haz the power, 2017-01-06 21:50:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a82983afecb4762005ac0d57809c...

[aberent, 2017-01-13 10:34:46]

aberent@chromium.org changed reviewers:
+ aberent@chromium.org

[aberent, 2017-01-13 10:34:47]

https://codereview.chromium.org/2614183002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java
(right):

https://codereview.chromium.org/2614183002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java:36:
//   - Backup & restore does not restore native pref, so this needs to update
it.
Why not simply add the native pref to the list of backed up prefs (see
chrome_backup_agent.cc)?