Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2617323002: Revert of [intl] Remove redundant type checking system (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
Yang, adamk, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [intl] Remove redundant type checking system (patchset #4 id:60001 of https://codereview.chromium.org/2600913002/ ) Reason for revert: Breaks noi18n. Original issue's description: > [intl] Remove redundant type checking system > > Previously, the Intl implementation tracked types two ways: > - In the intl_initialized_marker_symbol > - In various named properties of the intl_impl_object_symbol value > > As far as I can tell, these will never disagree with each other, > modulo bugs in Intl itself. This patch removes the second type > checking system. > > This reland includes a fixed type check for > Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl > method which is not bound. All future methods will follow this > pattern. > > BUG=v8:5751, chromium:677055, v8:4962 > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng > > Review-Url: https://codereview.chromium.org/2600913002 > Cr-Commit-Position: refs/heads/master@{#42118} > Committed: https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e594e25 TBR=yangguo@chromium.org,adamk@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5751, chromium:677055, v8:4962 Review-Url: https://codereview.chromium.org/2617323002 Cr-Commit-Position: refs/heads/master@{#42119} Committed: https://chromium.googlesource.com/v8/v8/+/b1e4f79e66ae7305ad034dc57004bbbc78f31441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -77 lines) Patch
M src/i18n.cc View 4 chunks +36 lines, -4 lines 0 comments Download
M src/js/i18n.js View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 13 chunks +29 lines, -9 lines 0 comments Download
D test/intl/bad-target.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/regress/regress-4962.js View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/regress/regress-677055.js View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [intl] Remove redundant type checking system
3 years, 11 months ago (2017-01-07 06:50:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617323002/1
3 years, 11 months ago (2017-01-07 06:50:38 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 06:50:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b1e4f79e66ae7305ad034dc57004bbbc78f...

Powered by Google App Engine
This is Rietveld 408576698