[intl] Remove redundant type checking system

[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751, chromium:677055, v8:4962
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

Review-Url: https://codereview.chromium.org/2600913002
Cr-Commit-Position: refs/heads/master@{#42118}
Committed: https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e594e25

[Dan Ehrenberg, 2016-12-27 16:29:42]

Description was changed from

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751
==========

to

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751,chromium:677055
==========

[Dan Ehrenberg, 2016-12-27 16:29:42]

littledan@chromium.org changed reviewers:
+ yangguo@chromium.org

[Dan Ehrenberg, 2016-12-27 16:29:47]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 16:29:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 16:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 16:54:29]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-12-27 19:55:54]

Description was changed from

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751,chromium:677055
==========

to

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751,chromium:677055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

[Dan Ehrenberg, 2016-12-27 19:56:22]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 19:56:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 20:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 20:03:38]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-12-27 20:15:06]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 20:15:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 20:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 20:40:21]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2017-01-06 03:04:58]

Description was changed from

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751,chromium:677055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

to

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751,chromium:677055, v8:4962
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

[Dan Ehrenberg, 2017-01-06 04:29:02]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 04:29:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 04:53:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 04:53:49]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2017-01-06 09:59:17]

littledan@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2017-01-06 22:40:29]

lgtm

[Dan Ehrenberg, 2017-01-07 02:30:31]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:30:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:54:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483756231165010,
"parent_rev": "586deecbb182cf471d390da59fe8143fcfc120c3", "commit_rev":
"aa8a2d2789f79c2c367db406e453b9044e594e25"}

[commit-bot: I haz the power, 2017-01-07 02:54:54]

Description was changed from

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751,chromium:677055, v8:4962
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

to

==========
[intl] Remove redundant type checking system

Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value

As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.

This reland includes a fixed type check for
Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
method which is not bound. All future methods will follow this
pattern.

BUG=v8:5751,chromium:677055, v8:4962
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

Review-Url: https://codereview.chromium.org/2600913002
Cr-Commit-Position: refs/heads/master@{#42118}
Committed:
https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e5...
==========

[commit-bot: I haz the power, 2017-01-07 02:54:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e5...

[Michael Achenbach, 2017-01-07 06:50:35]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2617323002/ by machenbach@chromium.org.

The reason for reverting is: Breaks noi18n..

[Michael Achenbach, 2017-01-07 11:00:19]

On 2017/01/07 06:50:35, Michael Achenbach (OOO) wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2617323002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Breaks noi18n..

[Michael Achenbach, 2017-01-07 11:02:26]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-01-07 11:02:27]

Guess the cq-include-trybot feature doesn't work well with triggered bots. CQ
has no idea about the triggered-by relation here. Therefore the triggered noi18n
bot didn't block this.

[tandrii(chromium), 2017-01-07 11:11:45]

On 2017/01/07 11:02:27, Michael Achenbach (OOO) wrote:
> Guess the cq-include-trybot feature doesn't work well with triggered bots. CQ
> has no idea about the triggered-by relation here. Therefore the triggered
noi18n
> bot didn't block this.

Yep, i think so too.
I guess the easiest way out is making v8_linux_noi18n_rel_ng recipe fail if
parent build properties are not not given,
then if this bot is in extra trybots list, direct CQ trigger will be red.
Ah, actually that won't work anyway, because CQ will immediately retry and it'll
fail again and CQ will abort the run :( 

I don't have good solution for you.