Remove ScopedVector from ios/.

Remove ScopedVector from ios/.

BUG=554289
Review-Url: https://codereview.chromium.org/2617243002
Cr-Commit-Position: refs/heads/master@{#442270}
Committed: https://chromium.googlesource.com/chromium/src/+/343e982bd7d96159d6452e8a6d3852624e1b90e8

[Avi (use Gerrit), 2017-01-06 23:18:44]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 23:19:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 23:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:26:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Avi (use Gerrit), 2017-01-06 23:27:50]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 23:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-01-06 23:35:48]

avi@chromium.org changed reviewers:
+ marq@chromium.org, rohitrao@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:39:58]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-01-09 09:50:14]

marq@chromium.org changed reviewers:
+ sdefresne@chromium.org

[marq (ping after 24h), 2017-01-09 09:50:15]

This looks fine to me, but  +sdefresne, who will catch issues that I have likely
missed.

[sdefresne, 2017-01-09 14:02:30]

lgtm

woot!!

https://codereview.chromium.org/2617243002/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
(left):

https://codereview.chromium.org/2617243002/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm:600:
savedForms_.weak_erase(it);
IIUC, this mean that we used to leak autofill::PasswordForm when we called this
method (I agree that the new code is correct). Thank you.

[Avi (use Gerrit), 2017-01-09 15:55:11]

https://codereview.chromium.org/2617243002/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
(left):

https://codereview.chromium.org/2617243002/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm:600:
savedForms_.weak_erase(it);
On 2017/01/09 14:02:29, sdefresne wrote:
> IIUC, this mean that we used to leak autofill::PasswordForm when we called
this
> method (I agree that the new code is correct). Thank you.

I was going to point this out in a comment but forgot. Yes, it seems we were
leaking here, and that's now fixed.

[Avi (use Gerrit), 2017-01-09 15:55:18]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-01-09 15:55:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 15:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 15:57:25]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Avi (use Gerrit), 2017-01-09 16:39:28]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-01-09 16:39:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2617243002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-09 16:39:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 16:52:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483979968097450,
"parent_rev": "2d4f26891b9a33d2d528d37a8fe2ee9be3228409", "commit_rev":
"343e982bd7d96159d6452e8a6d3852624e1b90e8"}

[commit-bot: I haz the power, 2017-01-09 16:53:04]

Description was changed from

==========
Remove ScopedVector from ios/.

BUG=554289
==========

to

==========
Remove ScopedVector from ios/.

BUG=554289

Review-Url: https://codereview.chromium.org/2617243002
Cr-Commit-Position: refs/heads/master@{#442270}
Committed:
https://chromium.googlesource.com/chromium/src/+/343e982bd7d96159d6452e8a6d38...
==========

[commit-bot: I haz the power, 2017-01-09 16:53:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/343e982bd7d96159d6452e8a6d38...