Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm

Issue 2617243002: Remove ScopedVector from ios/. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm b/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
index c75d5bd393bbb42fb15184f124a46441c20d562a..841affa3125823e4d66996bb0624798e37d441a2 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
@@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <memory>
+#include <vector>
+
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
@@ -62,27 +65,27 @@ TEST_F(BookmarkIOSUtilsUnitTest, segregateNodesByCreationDate) {
toSort.push_back(f2a);
toSort.push_back(f2b);
- ScopedVector<NodesSection> nodesSectionVector;
+ std::vector<std::unique_ptr<NodesSection>> nodesSectionVector;
bookmark_utils_ios::segregateNodes(toSort, nodesSectionVector);
// Expect the nodes to be sorted in reverse chronological order, grouped by
// month.
ASSERT_EQ(nodesSectionVector.size(), 4u);
- NodesSection* section = nodesSectionVector[0];
+ NodesSection* section = nodesSectionVector[0].get();
ASSERT_EQ(section->vector.size(), 1u);
EXPECT_EQ(section->vector[0], f2a);
- section = nodesSectionVector[1];
+ section = nodesSectionVector[1].get();
ASSERT_EQ(section->vector.size(), 2u);
EXPECT_EQ(section->vector[0], b);
EXPECT_EQ(section->vector[1], a);
- section = nodesSectionVector[2];
+ section = nodesSectionVector[2].get();
ASSERT_EQ(section->vector.size(), 2u);
EXPECT_EQ(section->vector[0], f1b);
EXPECT_EQ(section->vector[1], f1a);
- section = nodesSectionVector[3];
+ section = nodesSectionVector[3].get();
ASSERT_EQ(section->vector.size(), 1u);
EXPECT_EQ(section->vector[0], f2b);
}

Powered by Google App Engine
This is Rietveld 408576698