[Presentation API] Move Presentation API structs to public/common

[Presentation API] Move Presentation API structs to public/common

This moves presentation_session.{h,cc} and
presentation_connection_message.{h,cc} to public/common so Mojo typemaps can be
written for presentation.mojom.

BUG=679075
Review-Url: https://codereview.chromium.org/2617143006
Cr-Commit-Position: refs/heads/master@{#442691}
Committed: https://chromium.googlesource.com/chromium/src/+/f67aec28e1dc7f2d06865309ca99c16191a291d3

[mark a. foltz, 2017-01-07 01:42:01]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 01:42:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 01:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 01:49:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mark a. foltz, 2017-01-07 05:58:51]

mfoltz@chromium.org changed reviewers:
+ apacible@chromium.org, avi@chromium.org, zhaobin@chromium.org

[Avi (use Gerrit), 2017-01-08 03:42:27]

lgtm

[mark a. foltz, 2017-01-09 18:16:29]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2017-01-09 18:16:29]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2617143006/#ps20001
(title: "Revert OWNERS for crb/679129")

[commit-bot: I haz the power, 2017-01-09 18:16:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 18:23:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:23:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[apacible, 2017-01-09 18:28:24]

lgtm

[zhaobin, 2017-01-09 18:33:00]

lgtm

[mark a. foltz, 2017-01-09 19:01:24]

mfoltz@chromium.org changed reviewers:
+ nasko@chromium.org

[mark a. foltz, 2017-01-09 19:01:24]

+nasko from SECURITY_OWNERS for *_type_converters.h

[nasko, 2017-01-09 23:53:01]

Would the code moving to common be used by the renderer process?

https://codereview.chromium.org/2617143006/diff/20001/content/public/common/p...
File content/public/common/presentation_connection_message.h (right):

https://codereview.chromium.org/2617143006/diff/20001/content/public/common/p...
content/public/common/presentation_connection_message.h:26: struct
CONTENT_EXPORT PresentationConnectionMessage {
Can this really be used both from the browser and the renderer process?

[mark a. foltz, 2017-01-10 00:02:40]

On 2017/01/09 at 23:53:01, nasko wrote:
> Would the code moving to common be used by the renderer process?
> 
>
https://codereview.chromium.org/2617143006/diff/20001/content/public/common/p...
> File content/public/common/presentation_connection_message.h (right):
> 
>
https://codereview.chromium.org/2617143006/diff/20001/content/public/common/p...
> content/public/common/presentation_connection_message.h:26: struct
CONTENT_EXPORT PresentationConnectionMessage {
> Can this really be used both from the browser and the renderer process?

Right now, no, because the code in the renderer process manually marshals data
directly into the corresponding Mojo structs, e.g.

https://cs.chromium.org/chromium/src/content/renderer/presentation/presentati...

I'm trying to write Mojo typemaps to avoid this, as requested by dcheng@.  E.g.,

https://codereview.chromium.org/2613153003

(PresentationConnection isn't handled in that patch.  It will come in a followup
patch.)

To implement Mojo typemaps, it seems I need the mapped-to C++ types available to
both the browser and renderer.  It looks like I'll have to move
presentation.mojom to content/common as well.

m.

[nasko, 2017-01-10 17:44:01]

On 2017/01/10 00:02:40, mark a. foltz wrote:
> On 2017/01/09 at 23:53:01, nasko wrote:
> > Would the code moving to common be used by the renderer process?
> > 
> >
>
https://codereview.chromium.org/2617143006/diff/20001/content/public/common/p...
> > File content/public/common/presentation_connection_message.h (right):
> > 
> >
>
https://codereview.chromium.org/2617143006/diff/20001/content/public/common/p...
> > content/public/common/presentation_connection_message.h:26: struct
> CONTENT_EXPORT PresentationConnectionMessage {
> > Can this really be used both from the browser and the renderer process?
> 
> Right now, no, because the code in the renderer process manually marshals data
> directly into the corresponding Mojo structs, e.g.
> 
>
https://cs.chromium.org/chromium/src/content/renderer/presentation/presentati...

So technically it is indeed something that will be available and is used by the
renderer then.
 
> I'm trying to write Mojo typemaps to avoid this, as requested by dcheng@. 
E.g.,
> 
> https://codereview.chromium.org/2613153003
> 
> (PresentationConnection isn't handled in that patch.  It will come in a
followup
> patch.)
> 
> To implement Mojo typemaps, it seems I need the mapped-to C++ types available
to
> both the browser and renderer.  It looks like I'll have to move
> presentation.mojom to content/common as well.

Yeah, if you need to share a type among browser and renderer process, they will
have to be in a common directory.
 
> m.

[nasko, 2017-01-10 17:45:11]

Moving common types to content/public/common LGTM.

[mark a. foltz, 2017-01-10 18:45:15]

The CQ bit was checked by mfoltz@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:45:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 18:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:48:03]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[mark a. foltz, 2017-01-10 19:52:58]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2017-01-10 19:52:58]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
apacible@chromium.org, nasko@chromium.org, zhaobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2617143006/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-10 19:53:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:20:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484077978241000,
"parent_rev": "80353b52b8d21e3481f6e1b69eec86f3399bc5cf", "commit_rev":
"f67aec28e1dc7f2d06865309ca99c16191a291d3"}

[commit-bot: I haz the power, 2017-01-10 21:21:02]

Description was changed from

==========
[Presentation API] Move Presentation API structs to public/common

This moves presentation_session.{h,cc} and
presentation_connection_message.{h,cc} to public/common so Mojo typemaps can be
written for presentation.mojom.

BUG=679075
==========

to

==========
[Presentation API] Move Presentation API structs to public/common

This moves presentation_session.{h,cc} and
presentation_connection_message.{h,cc} to public/common so Mojo typemaps can be
written for presentation.mojom.

BUG=679075

Review-Url: https://codereview.chromium.org/2617143006
Cr-Commit-Position: refs/heads/master@{#442691}
Committed:
https://chromium.googlesource.com/chromium/src/+/f67aec28e1dc7f2d06865309ca99...
==========

[commit-bot: I haz the power, 2017-01-10 21:21:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f67aec28e1dc7f2d06865309ca99...