Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2622993002: [Presentation API] Move presentation.mojom to content/common/presentation (Closed)

Created:
3 years, 11 months ago by mark a. foltz
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] Move presentation.mojom to content/common/presentation To write Mojo typemaps for presentation.mojom using types in content/public/common, we need to move presentation.mojom to content/. See crbug.com/632623 BUG=679075

Patch Set 1 #

Patch Set 2 : Add dependent patch #

Patch Set 3 : Add dependent patchset (for realz) #

Patch Set 4 : Rebase #

Patch Set 5 : Fix #include and OWNERS #

Total comments: 1

Patch Set 6 : Fix tests. #

Patch Set 7 : Rebase #

Patch Set 8 : Fix Android build #

Patch Set 9 : Fix presentation_service_delegate. DEPS failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -471 lines) Patch
M chrome/browser/media/router/offscreen_presentation_manager.h View 1 2 3 4 5 6 2 chunks +10 lines, -7 lines 0 comments Download
M content/browser/DEPS View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 1 2 3 4 5 6 10 chunks +21 lines, -20 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 2 3 4 5 6 23 chunks +44 lines, -43 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 1 2 3 4 5 6 24 chunks +86 lines, -82 lines 0 comments Download
M content/browser/presentation/presentation_type_converters.h View 1 2 3 chunks +15 lines, -15 lines 0 comments Download
M content/browser/presentation/presentation_type_converters.cc View 1 chunk +18 lines, -17 lines 0 comments Download
M content/browser/presentation/presentation_type_converters_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +20 lines, -0 lines 0 comments Download
M content/common/presentation/OWNERS View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A + content/common/presentation/presentation.mojom View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/presentation_service_delegate.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/presentation_session.cc View 1 2 1 chunk +5 lines, -11 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 1 2 3 4 5 6 6 chunks +22 lines, -22 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 2 3 4 5 6 16 chunks +45 lines, -45 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher_unittest.cc View 1 2 3 4 5 6 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/presentation/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/public/platform/modules/presentation/presentation.mojom View 1 2 3 4 5 6 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
mark a. foltz
avayvod@ for overall review avi@ for content/ nasko@ for ipc/SECURITY_OWNERS jochen@ for third_party/WebKit
3 years, 11 months ago (2017-01-10 21:34:29 UTC) #5
Avi (use Gerrit)
lgtm
3 years, 11 months ago (2017-01-10 21:37:58 UTC) #6
jochen (gone - plz use gerrit)
webkit lgtm
3 years, 11 months ago (2017-01-11 09:50:22 UTC) #13
nasko
LGTM
3 years, 11 months ago (2017-01-11 18:45:05 UTC) #14
whywhat
lgtm although I've no idea why the browser test is failing... https://codereview.chromium.org/2622993002/diff/80001/content/public/common/presentation_session.cc File content/public/common/presentation_session.cc (right): ...
3 years, 11 months ago (2017-01-11 19:56:52 UTC) #15
mark a. foltz
On 2017/01/11 at 19:56:52, avayvod wrote: > lgtm although I've no idea why the browser ...
3 years, 11 months ago (2017-01-11 23:32:31 UTC) #18
mark a. foltz
3 years, 11 months ago (2017-01-24 00:36:14 UTC) #21
It looks like all I need is a one-line change to content/common/DEPS to avoid
having to do this.  I updated https://codereview.chromium.org/2613153003 and am
closing this.

Powered by Google App Engine
This is Rietveld 408576698