Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2617133004: Enable media_perftests on linux perfbot. (Closed)

Created:
3 years, 11 months ago by CalebRouleau
Modified:
3 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable media_perftests on linux perfbot. This required 1. Adding media_perftests to gn_isolate_map so that isolate can understand how to run them 2. Adding data dependencies to media_perftests target that are needed by the isolate script. 3. Added media_perftests to generate_perf_json.py configuration file. A previous version of this CL (https://codereview.chromium.org/2595123002) got reverted because I didn't do step 2. For that CL, I only tested media_perftests in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!) See test run: https://chromium-swarm.appspot.com/task?id=3390ffce2596c810&refresh=10&request_detail=true&show_raw=1 Follow up CL(s) will also add support on Mac, Windows, and Android. BUG=676188, 392620 Review-Url: https://codereview.chromium.org/2617133004 Cr-Commit-Position: refs/heads/master@{#443110} Committed: https://chromium.googlesource.com/chromium/src/+/98e3953123e42e1fe2d82ab301eb09f4a24bfca5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M media/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.perf.json View 1 chunk +19 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/perf/generate_perf_json.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 29 (14 generated)
CalebRouleau
PTAL
3 years, 11 months ago (2017-01-07 09:10:20 UTC) #4
sullivan
Replacing myself with dtu as a reviewer. dtu: do we expect this to increase time ...
3 years, 11 months ago (2017-01-08 21:11:06 UTC) #6
eyaich1
lgtm
3 years, 11 months ago (2017-01-09 14:27:24 UTC) #7
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-09 17:47:48 UTC) #8
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-10 00:53:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617133004/1
3 years, 11 months ago (2017-01-10 00:55:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 11 months ago (2017-01-10 02:57:20 UTC) #14
shatch
On 2017/01/10 02:57:20, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-10 16:11:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617133004/1
3 years, 11 months ago (2017-01-11 21:29:32 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/289760)
3 years, 11 months ago (2017-01-11 22:09:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617133004/1
3 years, 11 months ago (2017-01-11 22:19:38 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/211380) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 11 months ago (2017-01-11 22:28:18 UTC) #23
dtu
lgtm It's not a huge binary, so it's fine for build times.
3 years, 11 months ago (2017-01-11 23:29:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617133004/1
3 years, 11 months ago (2017-01-11 23:47:29 UTC) #26
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 01:30:22 UTC) #29
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98e3953123e42e1fe2d82ab301eb...

Powered by Google App Engine
This is Rietveld 408576698