|
|
Created:
3 years, 11 months ago by CalebRouleau Modified:
3 years, 11 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable media_perftests on linux perfbot.
This required
1. Adding media_perftests to gn_isolate_map so that isolate can understand how
to run them
2. Adding data dependencies to media_perftests target that are needed by the
isolate script.
3. Added media_perftests to generate_perf_json.py configuration file.
A previous version of this CL (https://codereview.chromium.org/2595123002) got
reverted because I didn't do step 2. For that CL, I only tested media_perftests
in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!)
See test run: https://chromium-swarm.appspot.com/task?id=3390ffce2596c810&refresh=10&request_detail=true&show_raw=1
Follow up CL(s) will also add support on Mac, Windows, and Android.
BUG=676188, 392620
Review-Url: https://codereview.chromium.org/2617133004
Cr-Commit-Position: refs/heads/master@{#443110}
Committed: https://chromium.googlesource.com/chromium/src/+/98e3953123e42e1fe2d82ab301eb09f4a24bfca5
Patch Set 1 #
Messages
Total messages: 29 (14 generated)
Description was changed from ========== Enable media_perftests on linux perfbot. This required 1. Adding media_perftests to gn_isolate_map so that isolate can understand how to run them 2. Adding data dependencies to media_perftests target that are needed by the isolate script. 3. Added media_perftests to generate_perf_json.py configuration file. A previous version of this CL (https://codereview.chromium.org/2595123002) got reverted because I didn't do step 2. For that CL, I only tested media_perftests in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!) BUG=676188,392620 ========== to ========== Enable media_perftests on linux perfbot. This required 1. Adding media_perftests to gn_isolate_map so that isolate can understand how to run them 2. Adding data dependencies to media_perftests target that are needed by the isolate script. 3. Added media_perftests to generate_perf_json.py configuration file. A previous version of this CL (https://codereview.chromium.org/2595123002) got reverted because I didn't do step 2. For that CL, I only tested media_perftests in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!) Follow up CL(s) will also add support on Mac, Windows, and Android. BUG=676188,392620 ==========
crouleau@chromium.org changed reviewers: + dalecurtis@chromium.org, eyaich@chromium.org, sullivan@chromium.org
Description was changed from ========== Enable media_perftests on linux perfbot. This required 1. Adding media_perftests to gn_isolate_map so that isolate can understand how to run them 2. Adding data dependencies to media_perftests target that are needed by the isolate script. 3. Added media_perftests to generate_perf_json.py configuration file. A previous version of this CL (https://codereview.chromium.org/2595123002) got reverted because I didn't do step 2. For that CL, I only tested media_perftests in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!) Follow up CL(s) will also add support on Mac, Windows, and Android. BUG=676188,392620 ========== to ========== Enable media_perftests on linux perfbot. This required 1. Adding media_perftests to gn_isolate_map so that isolate can understand how to run them 2. Adding data dependencies to media_perftests target that are needed by the isolate script. 3. Added media_perftests to generate_perf_json.py configuration file. A previous version of this CL (https://codereview.chromium.org/2595123002) got reverted because I didn't do step 2. For that CL, I only tested media_perftests in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!) See test run: https://chromium-swarm.appspot.com/task?id=3390ffce2596c810&refresh=10&reques... Follow up CL(s) will also add support on Mac, Windows, and Android. BUG=676188,392620 ==========
PTAL
sullivan@chromium.org changed reviewers: + dtu@chromium.org
Replacing myself with dtu as a reviewer. dtu: do we expect this to increase time on the builders at all? Will it build correctly for bisect? simonhatch: anything that needs to be added to ensure this test bisects? dtu, simonhatch: if you have any questions about the code to set which tests run on which builder, please ask eyaich before her leave!
lgtm
lgtm
crouleau@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by crouleau@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
On 2017/01/10 02:57:20, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux > (JOB_TIMED_OUT, no build URL) Requirements for bisect are generally that the binary gets built along with anything else that's built for perf (chromium_builder_perf on desktop -> looks like this is done, added to android_perf_bisect_builder in android/builder.py on android) and that the dashboard knows how to generate the command line. Looks like the dashboard already had media_perftests support, this is the command-line the dashboard will supply if you attempt to bisect: 'media_perftests': [ './out/Release/media_perftests', '--single-process-tests', ], Check if that's right, if not we need to modify that in https://github.com/catapult-project/catapult/blob/master/dashboard/dashboard/...
The CQ bit was checked by crouleau@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by crouleau@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm It's not a huge binary, so it's fine for build times.
The CQ bit was checked by crouleau@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1484178404965060, "parent_rev": "d20a89e7b56ad53a58f19edf4775528d066577d5", "commit_rev": "98e3953123e42e1fe2d82ab301eb09f4a24bfca5"}
Message was sent while issue was closed.
Description was changed from ========== Enable media_perftests on linux perfbot. This required 1. Adding media_perftests to gn_isolate_map so that isolate can understand how to run them 2. Adding data dependencies to media_perftests target that are needed by the isolate script. 3. Added media_perftests to generate_perf_json.py configuration file. A previous version of this CL (https://codereview.chromium.org/2595123002) got reverted because I didn't do step 2. For that CL, I only tested media_perftests in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!) See test run: https://chromium-swarm.appspot.com/task?id=3390ffce2596c810&refresh=10&reques... Follow up CL(s) will also add support on Mac, Windows, and Android. BUG=676188,392620 ========== to ========== Enable media_perftests on linux perfbot. This required 1. Adding media_perftests to gn_isolate_map so that isolate can understand how to run them 2. Adding data dependencies to media_perftests target that are needed by the isolate script. 3. Added media_perftests to generate_perf_json.py configuration file. A previous version of this CL (https://codereview.chromium.org/2595123002) got reverted because I didn't do step 2. For that CL, I only tested media_perftests in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!) See test run: https://chromium-swarm.appspot.com/task?id=3390ffce2596c810&refresh=10&reques... Follow up CL(s) will also add support on Mac, Windows, and Android. BUG=676188,392620 Review-Url: https://codereview.chromium.org/2617133004 Cr-Commit-Position: refs/heads/master@{#443110} Committed: https://chromium.googlesource.com/chromium/src/+/98e3953123e42e1fe2d82ab301eb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/98e3953123e42e1fe2d82ab301eb... |