Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2595123002:
Enable media_perftests to run on Windows, Mac, and Linux. (Closed)
|
Created:
4 years ago by CalebRouleau Modified:
4 years ago CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable media_perftests to run on Windows, Mac, and Linux.
BUG=676188, 392620
Committed: https://crrev.com/feb10cb7e15bb5378e6664722e7ae4b082bf9191
Cr-Commit-Position: refs/heads/master@{#440473}
Patch Set 1 #Patch Set 2 : Change shard to 3 for bots with other builds on 2. #
Messages
Total messages: 26 (15 generated)
Description was changed from ========== Enable media_perftests to run on Windows, Mac, and Linux. BUG=676188,392620 ========== to ========== Enable media_perftests to run on Windows, Mac, and Linux. BUG=676188,392620 ==========
crouleau@chromium.org changed reviewers: + eyaich@chromium.org
The CQ bit was checked by crouleau@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Would be nice to run on Android too.
On 2016/12/21 22:09:00, DaleCurtis_OOO_Dec14_Jan6 wrote: > Would be nice to run on Android too. I'll do another CL for that once this one lands.
lgtm The shard is meant to distribute the load. Maybe I would put 3 instead of 2 since all of the others are currently on 2? I don't think it matters much but we do have issues with sharding on some slower bots.
The CQ bit was checked by crouleau@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eyaich@chromium.org Link to the patchset: https://codereview.chromium.org/2595123002/#ps20001 (title: "Change shard to 3 for bots with other builds on 2.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
crouleau@chromium.org changed reviewers: + dpranke@google.com
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by crouleau@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482434929223560,
"parent_rev": "31910b71f2f6ff11a8845c413164e864e218aaaf", "commit_rev":
"f9aca8d6c3782285d1928aa148558bc9f7c93c50"}
Message was sent while issue was closed.
Description was changed from ========== Enable media_perftests to run on Windows, Mac, and Linux. BUG=676188,392620 ========== to ========== Enable media_perftests to run on Windows, Mac, and Linux. BUG=676188,392620 Review-Url: https://codereview.chromium.org/2595123002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable media_perftests to run on Windows, Mac, and Linux. BUG=676188,392620 Review-Url: https://codereview.chromium.org/2595123002 ========== to ========== Enable media_perftests to run on Windows, Mac, and Linux. BUG=676188,392620 Committed: https://crrev.com/feb10cb7e15bb5378e6664722e7ae4b082bf9191 Cr-Commit-Position: refs/heads/master@{#440473} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/feb10cb7e15bb5378e6664722e7ae4b082bf9191 Cr-Commit-Position: refs/heads/master@{#440473} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
