Use a new Supplement constructor for Supplement<Document> (Part 1)

Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617103002
Cr-Commit-Position: refs/heads/master@{#441911}
Committed: https://chromium.googlesource.com/chromium/src/+/110425bcd5ef3ea734625d084af49723990ae0c8

[haraken, 2017-01-06 07:22:33]

Description was changed from

==========
Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document
parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
==========

to

==========
Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document
parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[haraken, 2017-01-06 07:25:28]

Description was changed from

==========
Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document
parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document
parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[haraken, 2017-01-06 07:25:36]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-06 07:25:37]

PTAL

[sof, 2017-01-06 07:55:06]

lgtm

https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp (right):

https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp:79: if (host()->frame())
{
passing comment/thought - might there be a more self-explanatory naming of the
supplementable's |host()| ?

https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h
(right):

https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h:35:
protected:
nit: if this is a 'final', protected => private.

[haraken, 2017-01-06 07:57:29]

>
https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp (right):
> 
>
https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp:79: if
(host()->frame())
> {
> passing comment/thought - might there be a more self-explanatory naming of the
> supplementable's |host()| ?

Yeah, agreed. Shall we rename it to supplementable()?
 
>
https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h
> (right):
> 
>
https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h:35:
> protected:
> nit: if this is a 'final', protected => private.

Done.

[haraken, 2017-01-06 07:57:37]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-01-06 07:57:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2617103002/#ps40001
(title: "temp")

[commit-bot: I haz the power, 2017-01-06 07:57:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 10:06:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483689457181470,
"parent_rev": "78b9be0cd4da61618c21e4003f7cc84092684ccd", "commit_rev":
"110425bcd5ef3ea734625d084af49723990ae0c8"}

[commit-bot: I haz the power, 2017-01-06 10:07:25]

Description was changed from

==========
Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document
parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document
parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617103002
Cr-Commit-Position: refs/heads/master@{#441911}
Committed:
https://chromium.googlesource.com/chromium/src/+/110425bcd5ef3ea734625d084af4...
==========

[commit-bot: I haz the power, 2017-01-06 10:07:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/110425bcd5ef3ea734625d084af4...

[sof, 2017-01-08 12:40:07]

On 2017/01/06 07:57:29, haraken wrote:
> >
>
https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2617103002/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp:79: if
> (host()->frame())
> > {
> > passing comment/thought - might there be a more self-explanatory naming of
the
> > supplementable's |host()| ?
> 
> Yeah, agreed. Shall we rename it to supplementable()?
>  

supplementHost() (or supplementOwner()) is the only alternative suggestion i can
think of.