third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h - Issue 2617103002: Use a new Supplement constructor for Supplement<Document> (Part 1)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h

Issue 2617103002: Use a new Supplement constructor for Supplement<Document> (Part 1) (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp ('K') | « third_party/WebKit/Source/core/xml/DocumentXSLT.cpp ('k') | third_party/WebKit/Source/modules/storage/DOMWindowStorageController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef DOMWindowStorageController_h	5 #ifndef DOMWindowStorageController_h

6 #define DOMWindowStorageController_h	6 #define DOMWindowStorageController_h

7	7

8 #include "core/dom/Document.h"	8 #include "core/dom/Document.h"

9 #include "core/frame/LocalDOMWindow.h"	9 #include "core/frame/LocalDOMWindow.h"

10 #include "modules/ModulesExport.h"	10 #include "modules/ModulesExport.h"

(...skipping 14 matching lines...) Expand all Loading...
25 DECLARE_VIRTUAL_TRACE();	25 DECLARE_VIRTUAL_TRACE();

26	26

27 static const char* supplementName();	27 static const char* supplementName();

28 static DOMWindowStorageController& from(Document&);	28 static DOMWindowStorageController& from(Document&);

29	29

30 // Inherited from LocalDOMWindow::EventListenerObserver	30 // Inherited from LocalDOMWindow::EventListenerObserver

31 void didAddEventListener(LocalDOMWindow*, const AtomicString&) override;	31 void didAddEventListener(LocalDOMWindow*, const AtomicString&) override;

32 void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) override {}	32 void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) override {}

33 void didRemoveAllEventListeners(LocalDOMWindow*) override {}	33 void didRemoveAllEventListeners(LocalDOMWindow*) override {}

34	34

35 protected:	35 protected:
	sof 2017/01/06 07:55:06 nit: if this is a 'final', protected => private. nit: if this is a 'final', protected => private.
36 explicit DOMWindowStorageController(Document&);	36 explicit DOMWindowStorageController(Document&);

37

38 private:

39 Document& document() const { return *m_document; }

40

41 Member<Document> m_document;

42 };	37 };

43	38

44 } // namespace blink	39 } // namespace blink

45	40

46 #endif // DOMWindowStorageController_h	41 #endif // DOMWindowStorageController_h

OLD	NEW