Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 2616883003: When resetting compile jobs, delete the zone last (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

When resetting compile jobs, delete the zone last The destructors of the parse info, compile info, and compilation job might still access the zone BUG=none R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2616883003 Cr-Commit-Position: refs/heads/master@{#42089} Committed: https://chromium.googlesource.com/v8/v8/+/48b06536a7b9484df1ad33f79e2455024d4b9a71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-05 11:45:58 UTC) #1
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-05 11:46:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616883003/1
3 years, 11 months ago (2017-01-05 11:52:24 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 12:11:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/48b06536a7b9484df1ad33f79e2455024d4...

Powered by Google App Engine
This is Rietveld 408576698