Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: src/compiler-dispatcher/compiler-dispatcher-job.cc

Issue 2616883003: When resetting compile jobs, delete the zone last (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler-dispatcher/compiler-dispatcher-job.h" 5 #include "src/compiler-dispatcher/compiler-dispatcher-job.h"
6 6
7 #include "src/assert-scope.h" 7 #include "src/assert-scope.h"
8 #include "src/compilation-info.h" 8 #include "src/compilation-info.h"
9 #include "src/compiler-dispatcher/compiler-dispatcher-tracer.h" 9 #include "src/compiler-dispatcher/compiler-dispatcher-tracer.h"
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 return true; 243 return true;
244 } 244 }
245 245
246 void CompilerDispatcherJob::ResetOnMainThread() { 246 void CompilerDispatcherJob::ResetOnMainThread() {
247 DCHECK(ThreadId::Current().Equals(isolate_->thread_id())); 247 DCHECK(ThreadId::Current().Equals(isolate_->thread_id()));
248 248
249 parser_.reset(); 249 parser_.reset();
250 unicode_cache_.reset(); 250 unicode_cache_.reset();
251 character_stream_.reset(); 251 character_stream_.reset();
252 parse_info_.reset(); 252 parse_info_.reset();
253 zone_.reset();
254 handles_from_parsing_.reset(); 253 handles_from_parsing_.reset();
255 compile_info_.reset(); 254 compile_info_.reset();
256 compile_job_.reset(); 255 compile_job_.reset();
256 zone_.reset();
257 257
258 if (!source_.is_null()) { 258 if (!source_.is_null()) {
259 i::GlobalHandles::Destroy(Handle<Object>::cast(source_).location()); 259 i::GlobalHandles::Destroy(Handle<Object>::cast(source_).location());
260 source_ = Handle<String>::null(); 260 source_ = Handle<String>::null();
261 } 261 }
262 262
263 status_ = CompileJobStatus::kInitial; 263 status_ = CompileJobStatus::kInitial;
264 } 264 }
265 265
266 double CompilerDispatcherJob::EstimateRuntimeOfNextStepInMs() const { 266 double CompilerDispatcherJob::EstimateRuntimeOfNextStepInMs() const {
(...skipping 22 matching lines...) Expand all
289 case CompileJobStatus::kDone: 289 case CompileJobStatus::kDone:
290 return 0.0; 290 return 0.0;
291 } 291 }
292 292
293 UNREACHABLE(); 293 UNREACHABLE();
294 return 0.0; 294 return 0.0;
295 } 295 }
296 296
297 } // namespace internal 297 } // namespace internal
298 } // namespace v8 298 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698