Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2616873002: Update xmllite reference to new source location (Closed)

Created:
3 years, 11 months ago by kjellander_chromium
Modified:
3 years, 11 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update xmllite reference to new source location In https://codereview.chromium.org/2443903004/ all of third_party/webrtc/libjingle was replaced with a new imported copy in third_party/libjingle_xmpp. Unfortunately https://codereview.chromium.org/2586403003 was submitted in the meantime, before the code was deleted in the WebRTC repo and rolled into Chromium. This CL updates the last references to the old copy of the code, which should enable deleting it from WebRTC. BUG=webrtc:5539 TBR=sergeyu@chromium.org Committed: https://crrev.com/3ca72a793423f471aa8688e5228b7f75738efc63 Cr-Commit-Position: refs/heads/master@{#441609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/protocol/session_plugin.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_chromium
A change sneaked in at Dec 29 referencing the old code. This updates it, which ...
3 years, 11 months ago (2017-01-05 07:45:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616873002/1
3 years, 11 months ago (2017-01-05 07:45:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-05 08:18:52 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 08:22:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ca72a793423f471aa8688e5228b7f75738efc63
Cr-Commit-Position: refs/heads/master@{#441609}

Powered by Google App Engine
This is Rietveld 408576698