Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2586403003: [Chromoting] Add SessionPlugin in JingleSession (Closed)

Created:
4 years ago by Hzj_jie
Modified:
3 years, 11 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Add SessionPlugin in JingleSession This change adds SessionPlugin interface, and an Session::AddPlugin() function to attach SessionPlugin instances into Session and its derived classes. In JingleSession, the plugins will be executed after receiving a message or before sending a message. So a SessionPlugin implementation can read fields from and write to a message. Refer to change https://codereview.chromium.org/2586133002/, it shows how HostExperimentSessionPlugin works as a SessionPlugin. This is part of host experiment framework. BUG=650926 Committed: https://crrev.com/cf233ee72108ce3e3d35ecc7ba83a2e7d3726704 Cr-Commit-Position: refs/heads/master@{#441003}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Resolve review comments #

Total comments: 32

Patch Set 3 : Resolve review comments #

Total comments: 12

Patch Set 4 : Resolve review comments #

Total comments: 2

Patch Set 5 : Resolve review comments #

Total comments: 12

Patch Set 6 : Resolve review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -8 lines) Patch
M remoting/protocol/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/fake_session.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/fake_session.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_messages.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 2 3 4 5 3 chunks +13 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 3 4 5 8 chunks +58 lines, -8 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 2 3 4 5 8 chunks +93 lines, -0 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/session.h View 1 2 3 4 5 3 chunks +8 lines, -0 lines 0 comments Download
A remoting/protocol/session_plugin.h View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 64 (50 generated)
Hzj_jie
4 years ago (2016-12-20 03:34:08 UTC) #16
Jamie
Mostly looks good. I'll let Sergey give you the final sign-off, since he's more knowledgeable ...
4 years ago (2016-12-20 23:29:21 UTC) #17
Sergey Ulanov
https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/fake_session.cc File remoting/protocol/fake_session.cc (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/fake_session.cc#newcode107 remoting/protocol/fake_session.cc:107: void FakeSession::Attach(std::unique_ptr<SessionPlugin> plugin) {} NOTIMPLEMENTED() https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/jingle_messages.cc File remoting/protocol/jingle_messages.cc (right): ...
4 years ago (2016-12-21 01:38:35 UTC) #29
Hzj_jie
https://codereview.chromium.org/2586403003/diff/40001/remoting/protocol/session_plugin.h File remoting/protocol/session_plugin.h (right): https://codereview.chromium.org/2586403003/diff/40001/remoting/protocol/session_plugin.h#newcode26 remoting/protocol/session_plugin.h:26: // Attachs messages in |attachments|. This function will be ...
4 years ago (2016-12-21 01:54:44 UTC) #30
Hzj_jie
https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/fake_session.cc File remoting/protocol/fake_session.cc (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/fake_session.cc#newcode107 remoting/protocol/fake_session.cc:107: void FakeSession::Attach(std::unique_ptr<SessionPlugin> plugin) {} On 2016/12/21 01:38:34, Sergey Ulanov ...
4 years ago (2016-12-22 00:27:11 UTC) #38
Sergey Ulanov
https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/jingle_session_unittest.cc File remoting/protocol/jingle_session_unittest.cc (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/jingle_session_unittest.cc#newcode603 remoting/protocol/jingle_session_unittest.cc:603: ASSERT_EQ(client_plugin_->on_outgoing_count(), 2); On 2016/12/22 00:27:10, Hzj_jie wrote: > On ...
3 years, 12 months ago (2016-12-23 00:14:52 UTC) #39
Hzj_jie
https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/jingle_session_unittest.cc File remoting/protocol/jingle_session_unittest.cc (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/jingle_session_unittest.cc#newcode603 remoting/protocol/jingle_session_unittest.cc:603: ASSERT_EQ(client_plugin_->on_outgoing_count(), 2); On 2016/12/23 00:14:51, Sergey Ulanov wrote: > ...
3 years, 12 months ago (2016-12-24 00:09:55 UTC) #44
Sergey Ulanov
https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h File remoting/protocol/session_plugin.h (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h#newcode39 remoting/protocol/session_plugin.h:39: JingleMessage::ActionType action, On 2016/12/24 00:09:54, Hzj_jie wrote: > On ...
3 years, 11 months ago (2016-12-27 22:05:18 UTC) #45
Hzj_jie
https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h File remoting/protocol/session_plugin.h (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h#newcode39 remoting/protocol/session_plugin.h:39: JingleMessage::ActionType action, On 2016/12/27 22:05:18, Sergey Ulanov wrote: > ...
3 years, 11 months ago (2016-12-27 23:21:08 UTC) #48
Sergey Ulanov
A few more style-nits, but LGTM otherwise. https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h File remoting/protocol/session_plugin.h (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h#newcode39 remoting/protocol/session_plugin.h:39: JingleMessage::ActionType action, ...
3 years, 11 months ago (2016-12-29 00:37:58 UTC) #51
Hzj_jie
https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h File remoting/protocol/session_plugin.h (right): https://codereview.chromium.org/2586403003/diff/120001/remoting/protocol/session_plugin.h#newcode39 remoting/protocol/session_plugin.h:39: JingleMessage::ActionType action, On 2016/12/29 00:37:57, Sergey Ulanov wrote: > ...
3 years, 11 months ago (2016-12-29 03:07:57 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586403003/200001
3 years, 11 months ago (2016-12-29 23:11:50 UTC) #59
commit-bot: I haz the power
Committed patchset #6 (id:200001)
3 years, 11 months ago (2016-12-29 23:44:06 UTC) #62
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:53:43 UTC) #64
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/cf233ee72108ce3e3d35ecc7ba83a2e7d3726704
Cr-Commit-Position: refs/heads/master@{#441003}

Powered by Google App Engine
This is Rietveld 408576698