Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2616843005: Tiny fix for sloppy function map 'name' descriptor attributes (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tiny fix for sloppy function map 'name' descriptor attributes I can't actually figure out how to trigger a change in behavior here, but it looks like we should be passing the same attributes both to the accessor and the descriptor. R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2616843005 Cr-Commit-Position: refs/heads/master@{#42149} Committed: https://chromium.googlesource.com/v8/v8/+/2b961cec80f8403732b0809af620a9c186fa6533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
3 years, 11 months ago (2017-01-06 00:37:41 UTC) #1
Toon Verwaest
I don't think you can; it's only relevant for other style accessor info objects I ...
3 years, 11 months ago (2017-01-09 10:17:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616843005/1
3 years, 11 months ago (2017-01-09 17:51:50 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:17:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2b961cec80f8403732b0809af620a9c186f...

Powered by Google App Engine
This is Rietveld 408576698