Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/factory.cc

Issue 2616843005: Tiny fix for sloppy function map 'name' descriptor attributes (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/factory.h" 5 #include "src/factory.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/allocation-site-scopes.h" 8 #include "src/allocation-site-scopes.h"
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2646 matching lines...) Expand 10 before | Expand all | Expand 10 after
2657 Handle<AccessorInfo> length = 2657 Handle<AccessorInfo> length =
2658 Accessors::FunctionLengthInfo(isolate(), roc_attribs); 2658 Accessors::FunctionLengthInfo(isolate(), roc_attribs);
2659 { // Add length. 2659 { // Add length.
2660 Descriptor d = Descriptor::AccessorConstant( 2660 Descriptor d = Descriptor::AccessorConstant(
2661 Handle<Name>(Name::cast(length->name())), length, roc_attribs); 2661 Handle<Name>(Name::cast(length->name())), length, roc_attribs);
2662 map->AppendDescriptor(&d); 2662 map->AppendDescriptor(&d);
2663 } 2663 }
2664 2664
2665 STATIC_ASSERT(JSFunction::kNameDescriptorIndex == 1); 2665 STATIC_ASSERT(JSFunction::kNameDescriptorIndex == 1);
2666 Handle<AccessorInfo> name = 2666 Handle<AccessorInfo> name =
2667 Accessors::FunctionNameInfo(isolate(), ro_attribs); 2667 Accessors::FunctionNameInfo(isolate(), roc_attribs);
2668 { // Add name. 2668 { // Add name.
2669 Descriptor d = Descriptor::AccessorConstant( 2669 Descriptor d = Descriptor::AccessorConstant(
2670 Handle<Name>(Name::cast(name->name())), name, roc_attribs); 2670 Handle<Name>(Name::cast(name->name())), name, roc_attribs);
2671 map->AppendDescriptor(&d); 2671 map->AppendDescriptor(&d);
2672 } 2672 }
2673 Handle<AccessorInfo> args = 2673 Handle<AccessorInfo> args =
2674 Accessors::FunctionArgumentsInfo(isolate(), ro_attribs); 2674 Accessors::FunctionArgumentsInfo(isolate(), ro_attribs);
2675 { // Add arguments. 2675 { // Add arguments.
2676 Descriptor d = Descriptor::AccessorConstant( 2676 Descriptor d = Descriptor::AccessorConstant(
2677 Handle<Name>(Name::cast(args->name())), args, ro_attribs); 2677 Handle<Name>(Name::cast(args->name())), args, ro_attribs);
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
2782 Handle<AccessorInfo> prototype = 2782 Handle<AccessorInfo> prototype =
2783 Accessors::FunctionPrototypeInfo(isolate(), rw_attribs); 2783 Accessors::FunctionPrototypeInfo(isolate(), rw_attribs);
2784 Descriptor d = Descriptor::AccessorConstant( 2784 Descriptor d = Descriptor::AccessorConstant(
2785 Handle<Name>(Name::cast(prototype->name())), prototype, rw_attribs); 2785 Handle<Name>(Name::cast(prototype->name())), prototype, rw_attribs);
2786 map->AppendDescriptor(&d); 2786 map->AppendDescriptor(&d);
2787 } 2787 }
2788 } 2788 }
2789 2789
2790 } // namespace internal 2790 } // namespace internal
2791 } // namespace v8 2791 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698