Remove Print As Image for Mac and Win

Remove Print As Image for Mac and Win

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2616783002
Cr-Commit-Position: refs/heads/master@{#443080}
Committed: https://chromium.googlesource.com/chromium/src/+/c2a83f80ca89c9a6c5305816ea4212bad71a1eed

[rbpotter, 2017-01-05 00:27:49]

Description was changed from

==========
Remove Print As Image for Mac and Win

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
==========

to

==========
Remove Print As Image for Mac and Win

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2017-01-05 00:28:02]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 00:28:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 01:39:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 01:39:41]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2017-01-05 02:40:03]

Description was changed from

==========
Remove Print As Image for Mac and Win

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove Print As Image for Mac and Win

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2017-01-05 02:40:04]

rbpotter@chromium.org changed reviewers:
+ dpapad@chromium.org

[rbpotter, 2017-01-05 02:40:20]

rbpotter@chromium.org changed reviewers:
+ isherman@chromium.org

[dpapad, 2017-01-05 21:43:03]

https://codereview.chromium.org/2616783002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2616783002/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2109: #if defined(OS_CHROMEOS) ||
defined(OS_LINUX)
Is this equivalent to !OS_MACOSX && !OS_WIN?

Asking because there are more OS values, see
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=OS_WIN&sq=package:chromiu...,
and with this change it seems that we are removing this feature from more than
just Mac and Win.

[rbpotter, 2017-01-06 01:18:17]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:19:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-01-06 01:26:48]

https://codereview.chromium.org/2616783002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2616783002/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2109: #if defined(OS_CHROMEOS) ||
defined(OS_LINUX)
On 2017/01/05 21:43:03, dpapad wrote:
> Is this equivalent to !OS_MACOSX && !OS_WIN?
> 
> Asking because there are more OS values, see
>
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=OS_WIN&sq=package:chromiu...,
> and with this change it seems that we are removing this feature from more than
> just Mac and Win.
> 

Not sure if any other platforms besides Mac/Win/Linux/CrOS have print preview
enabled, but in case they do I have changed everything to !Mac and !Win to
ensure it is only removed from those platforms.

[commit-bot: I haz the power, 2017-01-06 02:22:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:22:09]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-01-06 17:09:40]

https://codereview.chromium.org/2616783002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview.js (right):

https://codereview.chromium.org/2616783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview.js:70: GEN('#if defined(OS_CHROMEOS) ||
defined(OS_LINUX)');
This needs to be changed too, right?

https://codereview.chromium.org/2616783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview.js:553: var rasterizeEnabled =
!cr.isWindows && !cr.isMac;
Can this be moved in the constructor of PrintPreviewWebUITest (lines 13-17)? Or
is cr.isWindows and cr.isMac not defined yet at that point?

[rbpotter, 2017-01-06 19:32:02]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[rbpotter, 2017-01-06 19:32:34]

https://codereview.chromium.org/2616783002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview.js (right):

https://codereview.chromium.org/2616783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview.js:70: GEN('#if defined(OS_CHROMEOS) ||
defined(OS_LINUX)');
On 2017/01/06 17:09:40, dpapad wrote:
> This needs to be changed too, right?

Done.

https://codereview.chromium.org/2616783002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview.js:553: var rasterizeEnabled =
!cr.isWindows && !cr.isMac;
On 2017/01/06 17:09:40, dpapad wrote:
> Can this be moved in the constructor of PrintPreviewWebUITest (lines 13-17)?
Or
> is cr.isWindows and cr.isMac not defined yet at that point?

cr is not defined at that point.

[commit-bot: I haz the power, 2017-01-06 19:33:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:28:54]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-01-06 22:09:03]

fieldtrial_testing_config.json lgtm

[dpapad, 2017-01-11 19:25:01]

LGTM

[rbpotter, 2017-01-11 19:52:34]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 19:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:11:23]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[rbpotter, 2017-01-11 22:08:05]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:08:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:11:46]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2017-01-12 00:16:50]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:18:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:27:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484180210997510,
"parent_rev": "eea21c858d184a593903840cbaaa08339f6ac603", "commit_rev":
"c2a83f80ca89c9a6c5305816ea4212bad71a1eed"}

[commit-bot: I haz the power, 2017-01-12 00:28:50]

Description was changed from

==========
Remove Print As Image for Mac and Win

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove Print As Image for Mac and Win

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2616783002
Cr-Commit-Position: refs/heads/master@{#443080}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2a83f80ca89c9a6c5305816ea42...
==========

[commit-bot: I haz the power, 2017-01-12 00:28:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c2a83f80ca89c9a6c5305816ea42...

[Lei Zhang, 2017-02-25 01:39:25]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-02-25 01:39:26]

https://codereview.chromium.org/2616783002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview.js (right):

https://codereview.chromium.org/2616783002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview.js:531: if (!cr.isWindows && !cr.isMac) {
Should we make a function so we don't have to write "!cr.isWindows && !cr.isMac"
multiple times?