Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: chrome/browser/about_flags.cc

Issue 2616783002: Remove Print As Image for Mac and Win (Closed)
Patch Set: Fix last OS check Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index d108577111adaca2c3c4b814fc86712e8d7accad..e0de1d6121a81049333c7e74a5e89ddb36d3e154 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2104,13 +2104,15 @@ const FeatureEntry kFeatureEntries[] = {
features::kDisplayPersistenceToggleInPermissionPrompts)},
#endif
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
+#if !defined(OS_WIN) && !defined(OS_MACOSX)
{"print-pdf-as-image", IDS_FLAGS_PRINT_PDF_AS_IMAGE_NAME,
IDS_FLAGS_PRINT_PDF_AS_IMAGE_DESCRIPTION, kOsDesktop,
FEATURE_VALUE_TYPE(features::kPrintPdfAsImage)},
+#endif // !defined(OS_WIN) && !defined(OS_MACOSX)
{"print-scaling", IDS_FLAGS_PRINT_SCALING_NAME,
IDS_FLAGS_PRINT_SCALING_DESCRIPTION, kOsDesktop,
FEATURE_VALUE_TYPE(features::kPrintScaling)},
-#endif // !defined(OS_ANDROID)
+#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
#if defined(OS_ANDROID)
{"enable-consistent-omnibox-geolocation",
IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_NAME,
@@ -2124,7 +2126,7 @@ const FeatureEntry kFeatureEntries[] = {
{"web-payments-modifiers", IDS_FLAGS_WEB_PAYMENTS_MODIFIERS_NAME,
IDS_FLAGS_WEB_PAYMENTS_MODIFIERS_DESCRIPTION, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kWebPaymentsModifiers)},
-#endif
+#endif // !defined(OS_ANDROID)
{"cross-process-guests", IDS_FLAGS_CROSS_PROCESS_GUEST_VIEW_ISOLATION_NAME,
IDS_FLAGS_CROSS_PROCESS_GUEST_VIEW_ISOLATION_DESCRIPTION, kOsDesktop,
FEATURE_VALUE_TYPE(features::kGuestViewCrossProcessFrames)},

Powered by Google App Engine
This is Rietveld 408576698