Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2613813002: Change web_ui testing code to avoid using JS router/proxyClass directly. (Closed)

Created:
3 years, 11 months ago by yzshen1
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, extensions-reviews_chromium.org, feature-vr-reviews_chromium.org, halliwell+watch_chromium.org, jam, lcwu+watch_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change web_ui testing code to avoid using JS router/proxyClass directly. The previous code didn't validate incoming messages at all. BUG=579646 Review-Url: https://codereview.chromium.org/2613813002 Cr-Commit-Position: refs/heads/master@{#443020} Committed: https://chromium.googlesource.com/chromium/src/+/b59d006f624c34344e9835ed99d8279d4aa5701e

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M content/test/data/web_ui_mojo.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yzshen1
Hi, Ken. Would you please take a look at this small CL? It used to ...
3 years, 11 months ago (2017-01-09 22:57:02 UTC) #2
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-10 17:07:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613813002/60001
3 years, 11 months ago (2017-01-11 19:14:59 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:30:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b59d006f624c34344e9835ed99d8...

Powered by Google App Engine
This is Rietveld 408576698