Reference table via the cell for collapsed border display item client

Reference table via the cell for collapsed border display item client

BUG=676974
Committed: https://crrev.com/307f8cadc888653def2bfdc1a01978b411e718b0
Cr-Commit-Position: refs/heads/master@{#441322}

[Xianzhu, 2017-01-03 21:31:22]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[Xianzhu, 2017-01-03 21:31:22]

This is similar to https://codereview.chromium.org/2522923003, but I failed to
reproduce the bug and create a test case.

The clusterfuzz case is about that an anonymous table wrapper is created under
an original table (which becomes a normal block), and some table cell is moved
to the new table. There seems some underlying issue about cached collapsed
border invalidation, and I need to investigate more to figure it out. I would
like to land this CL to fix the memory issue first.

[Xianzhu, 2017-01-03 21:31:56]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 21:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-01-03 21:36:58]

https://codereview.chromium.org/2616463003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableCell.cpp (right):

https://codereview.chromium.org/2616463003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:1337:
WTF::wrapUnique(new CollapsedBorderValues(newValues));
The params don't seem to match the ctor, but I must be missing something?

[Xianzhu, 2017-01-03 21:48:56]

https://codereview.chromium.org/2616463003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableCell.cpp (right):

https://codereview.chromium.org/2616463003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:1337:
WTF::wrapUnique(new CollapsedBorderValues(newValues));
On 2017/01/03 21:36:58, wkorman wrote:
> The params don't seem to match the ctor, but I must be missing something?

This uses the default copy constructor. I think this is fine this class which is
almost like a structure.

[wkorman, 2017-01-03 22:05:36]

lgtm

https://codereview.chromium.org/2616463003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableCell.cpp (right):

https://codereview.chromium.org/2616463003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:1337:
WTF::wrapUnique(new CollapsedBorderValues(newValues));
On 2017/01/03 at 21:48:56, Xianzhu wrote:
> On 2017/01/03 21:36:58, wkorman wrote:
> > The params don't seem to match the ctor, but I must be missing something?
> 
> This uses the default copy constructor. I think this is fine this class which
is almost like a structure.

Ah, LOL, ok.

[commit-bot: I haz the power, 2017-01-03 22:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 22:57:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-01-04 01:56:48]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-01-04 01:56:48]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2616463003/#ps40001
(title: "Avoid copy constructor")

[commit-bot: I haz the power, 2017-01-04 01:57:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 05:09:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483495008033380,
"parent_rev": "c85a99013886e268418546a53039970238420940", "commit_rev":
"6a606e04da713860eace398b9789e6c0387fede9"}

[commit-bot: I haz the power, 2017-01-04 05:10:35]

Description was changed from

==========
Reference table via the cell for collapsed border display item client

BUG=676974
==========

to

==========
Reference table via the cell for collapsed border display item client

BUG=676974

Review-Url: https://codereview.chromium.org/2616463003
==========

[commit-bot: I haz the power, 2017-01-04 05:10:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 05:14:02]

Description was changed from

==========
Reference table via the cell for collapsed border display item client

BUG=676974

Review-Url: https://codereview.chromium.org/2616463003
==========

to

==========
Reference table via the cell for collapsed border display item client

BUG=676974

Committed: https://crrev.com/307f8cadc888653def2bfdc1a01978b411e718b0
Cr-Commit-Position: refs/heads/master@{#441322}
==========

[commit-bot: I haz the power, 2017-01-04 05:14:03]

Patchset 3 (id:??) landed as
https://crrev.com/307f8cadc888653def2bfdc1a01978b411e718b0
Cr-Commit-Position: refs/heads/master@{#441322}