Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2522923003: Reference table row via the cell for row background display item client. (Closed)

Created:
4 years, 1 month ago by wkorman
Modified:
4 years, 1 month ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, chrishtr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reference table row via the cell for row background display item client. BUG=666800 Committed: https://crrev.com/91b1dd79c0916b9c329058622919f190958ec626 Cr-Commit-Position: refs/heads/master@{#434110}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Integrate feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
wkorman
There's an open question (I just haven't traced further) re: why we see the ASIDE ...
4 years, 1 month ago (2016-11-23 00:29:19 UTC) #2
Xianzhu
https://codereview.chromium.org/2522923003/diff/1/third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html File third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html (right): https://codereview.chromium.org/2522923003/diff/1/third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html#newcode7 third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html:7: .c13 { display: table-cell; border-style: ridge; will-change: transform; } ...
4 years, 1 month ago (2016-11-23 00:56:25 UTC) #3
Xianzhu
On 2016/11/23 00:29:19, wkorman wrote: > There's an open question (I just haven't traced further) ...
4 years, 1 month ago (2016-11-23 00:57:22 UTC) #4
wkorman
On 2016/11/23 00:29:19, wkorman wrote: > There's an open question (I just haven't traced further) ...
4 years, 1 month ago (2016-11-23 01:02:49 UTC) #5
wkorman
https://codereview.chromium.org/2522923003/diff/1/third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html File third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html (right): https://codereview.chromium.org/2522923003/diff/1/third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html#newcode7 third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html:7: .c13 { display: table-cell; border-style: ridge; will-change: transform; } ...
4 years, 1 month ago (2016-11-23 02:05:22 UTC) #6
Xianzhu
lgtm
4 years, 1 month ago (2016-11-23 02:44:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522923003/20001
4 years, 1 month ago (2016-11-23 02:45:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-23 04:12:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 04:16:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91b1dd79c0916b9c329058622919f190958ec626
Cr-Commit-Position: refs/heads/master@{#434110}

Powered by Google App Engine
This is Rietveld 408576698