Prerender: avoid race condition with canceling prerender in test.

Prerender: avoid race condition with canceling prerender in test.

The test which started flaking started two prerenderers, the second which canceled the first. ChromeOS in particular exposed a race condition where the first prerender would complete before the second had a chance to cancel it. This in retrospect obvious situation exists elsewhere and has an easy fix in a HangingFirstRequestInterceptor which stalls the first prerender indefinitely, causing it to be reliably canceled by the second.

BUG=679090
TBR=droger

Review-Url: https://codereview.chromium.org/2616383002
Cr-Commit-Position: refs/heads/master@{#442918}
Committed: https://chromium.googlesource.com/chromium/src/+/841efc17964ac66ffa6b8b5ff63436f4ff6d52c1

[mattcary, 2017-01-09 09:57:59]

mattcary@chromium.org changed reviewers:
+ lizeb@chromium.org

[Benoit L, 2017-01-09 10:39:25]

On 2017/01/09 09:58:00, mattcary wrote:

lgtm

[mattcary, 2017-01-09 10:50:32]

The CQ bit was checked by mattcary@chromium.org

[mattcary, 2017-01-09 10:50:42]

The CQ bit was unchecked by mattcary@chromium.org

[mattcary, 2017-01-09 10:51:29]

The CQ bit was checked by mattcary@chromium.org

[commit-bot: I haz the power, 2017-01-09 10:51:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 10:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 10:58:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mattcary, 2017-01-09 10:59:30]

Description was changed from

==========
Prerender: avoid race condition with canceling prerender in test.

BUG=679090
==========

to

==========
Prerender: avoid race condition with canceling prerender in test.

BUG=679090
==========

[mattcary, 2017-01-09 10:59:30]

mattcary@chromium.org changed reviewers:
+ droger@chromium.org

[mattcary, 2017-01-09 10:59:43]

+droger to review for prerender owner.

[mattcary, 2017-01-09 14:46:14]

Description was changed from

==========
Prerender: avoid race condition with canceling prerender in test.

BUG=679090
==========

to

==========
Prerender: avoid race condition with canceling prerender in test.

BUG=679090

TBR=droger
==========

[mattcary, 2017-01-09 14:46:49]

The CQ bit was checked by mattcary@chromium.org

[commit-bot: I haz the power, 2017-01-09 14:47:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 15:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 15:20:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[droger, 2017-01-11 15:20:07]

lgtm (once the debugging code is removed).

Can add more details to the description of the CL?

[mattcary, 2017-01-11 15:39:04]

Description was changed from

==========
Prerender: avoid race condition with canceling prerender in test.

BUG=679090

TBR=droger
==========

to

==========
Prerender: avoid race condition with canceling prerender in test.

The test which started flaking started two prerenderers, the second which
canceled the first. ChromeOS in particular exposed a race condition where the
first prerender would complete before the second had a chance to cancel it. This
in retrospect obvious situation exists elsewhere and has an easy fix in a
HangingFirstRequestInterceptor which stalls the first prerender indefinitely,
causing it to be reliably canceled by the second.

BUG=679090

TBR=droger
==========

[mattcary, 2017-01-11 15:39:11]

On 2017/01/11 15:20:07, droger wrote:
> lgtm (once the debugging code is removed).
> 
> Can add more details to the description of the CL?

Done

[mattcary, 2017-01-11 15:47:43]

The CQ bit was checked by mattcary@chromium.org

[mattcary, 2017-01-11 15:47:43]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org,
droger@chromium.org
Link to the patchset: https://codereview.chromium.org/2616383002/#ps160001
(title: "remove unused test file fetch complexity")

[commit-bot: I haz the power, 2017-01-11 15:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:21:08]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484149663658580,
"parent_rev": "9dddc3fac1b1033d6ae85cad37a15c831fe7c156", "commit_rev":
"841efc17964ac66ffa6b8b5ff63436f4ff6d52c1"}

[commit-bot: I haz the power, 2017-01-11 16:21:41]

Description was changed from

==========
Prerender: avoid race condition with canceling prerender in test.

The test which started flaking started two prerenderers, the second which
canceled the first. ChromeOS in particular exposed a race condition where the
first prerender would complete before the second had a chance to cancel it. This
in retrospect obvious situation exists elsewhere and has an easy fix in a
HangingFirstRequestInterceptor which stalls the first prerender indefinitely,
causing it to be reliably canceled by the second.

BUG=679090

TBR=droger
==========

to

==========
Prerender: avoid race condition with canceling prerender in test.

The test which started flaking started two prerenderers, the second which
canceled the first. ChromeOS in particular exposed a race condition where the
first prerender would complete before the second had a chance to cancel it. This
in retrospect obvious situation exists elsewhere and has an easy fix in a
HangingFirstRequestInterceptor which stalls the first prerender indefinitely,
causing it to be reliably canceled by the second.

BUG=679090

TBR=droger

Review-Url: https://codereview.chromium.org/2616383002
Cr-Commit-Position: refs/heads/master@{#442918}
Committed:
https://chromium.googlesource.com/chromium/src/+/841efc17964ac66ffa6b8b5ff634...
==========

[commit-bot: I haz the power, 2017-01-11 16:21:42]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/841efc17964ac66ffa6b8b5ff634...